Response Code Error about codeigniter-paypal-ipn

[brwnll]

Would the fact that the order is in the DB cause the library to return a 500 error if PayPal attempts to resend the IPN?

[alexanderdean]

Hi smalldogs - what are you seeing in your ipn_log table - are there any messages of type ERROR in there?

[brwnll]

Negative. Of my last 100 rows of ipn_log all are SUCCESS

[alexanderdean]

Weird... Could your IPN CodeIgniter controller be doing something to cause an error after the codeigniter-paypal-ipn code has run? What return code do you see in your browser (use Chrome Developer Tools) when you replay a 500ed order directly in your browser?

[brwnll]

There was an error in my codeigniter mail sending, resulting in all validations and db calls to be executed as expected, but still give PayPal a 500 response because of the email error.

[alexanderdean]

Okay cool - thanks for letting me know!

[donjakobo]

I ran into the same issue, I would suggest a code change to have the mailing (smarty) DISABLED by default, and let the user enable their method of notification (in my case I use an internal app method via the DB to notify, no need for emails)

[alexanderdean]

Thanks Don for your comment and pull request. The example controller was originally meant just to give a flavour of how an IPN response can be handled (I don't view it as part of the library itself), but it looks like people are using it rote and then coming a cropper.

The trouble with commenting out the emailing is that I know people will then start running into the opposite problem: i.e. they will deploy the example controller without checking it, and then wonder why they are not receiving any notifications about their orders. To get around this, I'm going to split example.php into example-no-notification.php and example-smarty-email-notification.php. Then it should be pretty error proof and people can choose which example they want...

[donjakobo]

@alexanderdean makes sense, thanks :)
I was one of those few that didn't need the notification as an email, added my own piece but totally forgot about the email, I commented out the 'sending', as I was working quick to add paypal functionality.

My sandbox tests worked, so I proceeded to production where I kept getting good responses by paypal was getting ipn failures. So I realized then this was the cause after further review.

[alexanderdean]

Thanks @donjakobo - I'm sorry you got caught by that, thanks for bringing it to my attention so we can stop other people getting caught out too! I've made the split of example.php now and updated the README too - if you spot anything else, feel free to do another pull request...

[donjakobo]

@alexanderdean thanks for the quick response. No worries, getting caught on this thing was my own doing as I rushed what I needed to do. If it wasn't for you guys I wouldn't even have had a library to utilize so I'm far better off! Thanks!

[alexanderdean]

No worries - glad it's useful!