GithubHelp home page GithubHelp logo

Tests required about diff-so-fancy HOT 6 CLOSED

paulirish avatar paulirish commented on May 18, 2024
Tests required

from diff-so-fancy.

Comments (6)

cht8687 avatar cht8687 commented on May 18, 2024

so after the merge the task works without extra gnu-sed dependency can be marked as done right?

from diff-so-fancy.

stevemao avatar stevemao commented on May 18, 2024

Still missing comprehensive tests for it.
In fact, the tests would already fail if the default sed is not working.

from diff-so-fancy.

OJFord avatar OJFord commented on May 18, 2024

@paulirish Can you clarify the difference between resolving d-h when in $PATH, and the following item?

I'm not familiar with nvm'd npm installs, but Homebrew will complain (via brew doctor) if /usr/local/bin isn't in $PATH, which contains symlinks to diff-so-fancy, diff-highlight, etc. - so isn't just checking it works from $PATH sufficient? (c.f. #74, working on my brew install.)

from diff-so-fancy.

paulirish avatar paulirish commented on May 18, 2024

@OJFord I was just differentiating between the cases of 1 symlink involved vs 2+ symlinks. #36 also mentions the oddness around this.

from diff-so-fancy.

OJFord avatar OJFord commented on May 18, 2024

Oh I see, I hadn't realised this caused problems.

from diff-so-fancy.

paulirish avatar paulirish commented on May 18, 2024

@OJFord well the new readlink functionality at the top of the file loops to resolve, because asking for readlink foo can return another symlink. so its a test for that coverage.

from diff-so-fancy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.