Comments (3)
Writing an explanation here since Afshin asked of what we need to do to make this happen.
Basically when a Socket is holding a buffer, we want to tell the transport to write that buffer. Meanwhile, while the transport is writing it (for example, polling might have to wait for an incoming poll GET request), this buffer could grow at the socket level.
The socket will fire this callback when the drain
event is executed by the transport, which means the message was sent successfully. The extra complication is that while we're waiting on this event two other events can be emitted by the transport that should clean up this event: error
or close
. For example, the client might not re-open a GET request, triggering a timeout and a close
. Or the write could fail and an error
is emitted followed by a close
(see websocket write
callback).
The other extra complication is that we need to keep track of callbacks even when the transport is not writable yet (when things just get buffered at the socket).
FInally, it'd be cool to emit an event when the socket is closed and things didn't get flushed out (basically when a writeBuffer
has items).
from engine.io.
Thanks @guille, I'll start implementing this one right now.
from engine.io.
Also important is to consider
Basically instead of always assuming that things are going to be handled well by the transport and resetting the writeBuffer, we should keep track of the length of the writeBuffer in the closure that's being passed down to the transport, then slice the writeBuffer it it succeeds (because it could keep growing after we commit that buffer to the transport)
from engine.io.
Related Issues (20)
- TypeError: Cannot destructure property 'Server' of '_engineIo.default' HOT 5
- Customize response headers with Express middleware HOT 6
- Possible error in websocket code HOT 2
- clientsCount property of server... why need to keep this private, HOT 1
- In package.json, move @types/* from dependencies to devDependencies HOT 9
- Log with pino-http middleware raises TypeError: res.on is not a function HOT 1
- Latest uWs not working HOT 5
- ReferenceError: TextDecoder is not defined HOT 5
- Getting unexpected messages from some clients HOT 2
- Node.js versions below 10.2 are not compatible with the latest version 6.5.1. HOT 1
- WebTransport If the length of the data block exceeds maxDatagramSize, the server will be unable to receive the complete message (the client will not send the complete message). HOT 2
- Upgrading from polling to webtransport will report engine invalid WebTransport handshake. HOT 8
- The cache busting t query parameter does not work if multiple connections to the server are made HOT 3
- Add support for Node.js built-in WebSocket? HOT 7
- Upgrade 6.5.2 but the error of uWebsocket aborted write failed still appear HOT 1
- Add new transport: gRPC-Web HOT 2
- HTTP/2 Web Socket in Chrome not working HOT 2
- Send callback may not be called if message is sent during upgrade window HOT 2
- Cannot set `socket.request` to `null` because the property is read-only
- `websocket`: `send` callbacks are not all called if multiple messages are sent rapidly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from engine.io.