GithubHelp home page GithubHelp logo

Comments (3)

MartinKolarik avatar MartinKolarik commented on June 1, 2024

Upon further consideration, I think, regardless of this issue, it makes sense to have an option for creating separate channels for private rooms.

In our scenario, we have ~1k clients connected to ~10 servers, all communication is 1:1, and the connections stay open for a long time. Using separate channels significantly lowers the overall redis bandwidth, and the subscription/unsubscription impact shouldn't be significant. We could create our own "public" channel for each client, but using the existing ones seems like the cleanest option.

I implemented this, along with the previous fix, in #526. We're already running this in production, and it reduced the overall redis load by 50 - 60 % in our setup.

from socket.io-redis-adapter.

darrachequesne avatar darrachequesne commented on June 1, 2024

Hi! I could indeed reproduce the issue, thanks for reporting this.

This happens when calling io.to(someSocketId).emit("hello"); (which is also what happens with a RemoteSocket, under the hood). Classic socket.emit()'s are not affected though.

from socket.io-redis-adapter.

MartinKolarik avatar MartinKolarik commented on June 1, 2024

Classic socket.emit()'s are not affected though.

By this, you mean local emits? If yes, that's right, it only affects emits on remote sockets.

from socket.io-redis-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.