this.children is undefined for ParentBroadcastAdapter broadcast about socket.io

[darrachequesne]

Hi! That's weird, the children attribute should be initialized with the readonly tag:

socket.io/lib/parent-namespace.ts

Lines 116 to 118 in b0568b2

	constructor(parentNsp: any, private readonly children: Set<Namespace>) {
	super(parentNsp);
	}

In dist/parent-namespace.js:

class ParentBroadcastAdapter extends socket_io_adapter_1.Adapter {
    constructor(parentNsp, children) {
        super(parentNsp);
        this.children = children;
    }
    broadcast(packet, opts) {
        this.children.forEach((nsp) => {
            nsp.adapter.broadcast(packet, opts);
        });
    }
}

So I'm not sure how this.children can be undefined there... Thoughts?

[peterjuras]

Hi,
I'm experiencing the same issue. I'm using https://github.com/socketio/socket.io-redis-streams-adapter maybe that is the source of the issue?

[gkt5015]

Hi, is there an update on this?

I believe the issue here is that this.children isn't declared yet when super is called in the ParentNamespace class. The constructor of Namespace will call _initAdapter of the subclass with the undefined value. Prior to the change, this.children was enclosed in the function so it wasn't an issue.

Perhaps one way to change this would be:

class ParentBroadcastAdapter extends socket_io_adapter_1.Adapter {
    constructor(parentNsp) {
        super(parentNsp);
        this.parentNsp = parentNsp;
    }
    broadcast(packet, opts) {
        this.parentNsp.children.forEach((nsp) => {
            nsp.adapter.broadcast(packet, opts);
        });
    }
}