GithubHelp home page GithubHelp logo

Comments (20)

szydlovsky avatar szydlovsky commented on June 10, 2024 6

Hi everyone! We have identified the issue and can tell where the problem lies - but the potential fix has brought up many more questions than we thought and we are currently discussing what to do. Stay tuned ℒ️

from react-native-reanimated.

emzet93 avatar emzet93 commented on June 10, 2024 3

Here is patch created from @szydlovsky PR. Can be used with patch-package:

react-native-reanimated+3.10.0.patch

from react-native-reanimated.

quocluongha avatar quocluongha commented on June 10, 2024 3

I also experience this issue in the latest version (3.11.0)

from react-native-reanimated.

efstathiosntonas avatar efstathiosntonas commented on June 10, 2024 3

@szydlovsky after applying patch 3.11.0 life got back to normal πŸ˜…. Thank you!

from react-native-reanimated.

szydlovsky avatar szydlovsky commented on June 10, 2024 2

Hey everyone! As the fix got merged it should be available in the next nightly build at around 2AM CEST time - see npm page. It will also be there in the next stable version/patched version.

from react-native-reanimated.

NigelBreslaw avatar NigelBreslaw commented on June 10, 2024 1

Here is a reproduction https://snack.expo.dev/@nigelbreslaw/ra-flashlist-issue

from react-native-reanimated.

felixaa avatar felixaa commented on June 10, 2024 1

Same issue here. useAnimatedScrollHandler is not firing when using

const AnimatedFlashList = Animated.createAnimatedComponent(FlashList)

from react-native-reanimated.

szydlovsky avatar szydlovsky commented on June 10, 2024 1

@ElSeniorMikael no - the release 3.10.0 had a different purpose: #5963 (comment). The PR with fix will probably be reviewed next week. Until then you can install Reanimated the way I mentioned above.

from react-native-reanimated.

szydlovsky avatar szydlovsky commented on June 10, 2024 1

@efstathiosntonas Hi! Which patch did you use? This one is imperfect and I'd rather suggest latest nightly version - there was some stuff missing in the patch.

from react-native-reanimated.

efstathiosntonas avatar efstathiosntonas commented on June 10, 2024 1

let me give it a shot. I used the 3.10.0, I missed the 3.11.0 one.

from react-native-reanimated.

szydlovsky avatar szydlovsky commented on June 10, 2024 1

@efstathiosntonas That's a relief πŸ˜…

from react-native-reanimated.

fadi-quader-mox avatar fadi-quader-mox commented on June 10, 2024

I can reproduce this issue on 3.9.0 release

from react-native-reanimated.

MDG-RHawkins avatar MDG-RHawkins commented on June 10, 2024

Seeing same issue using:

"react-native": "0.71.15",
"react-native-reanimated": "^3.3.0",
"@shopify/flash-list": "^1.4.3",

However we only noticed the issue at first on Android as it was causing scrolling to not work at all. For iOS the scroll still functioned but the custom animation did not fire. In our case as the animation was only visible in a small number of scenarios it was not picked up in QA initially.

from react-native-reanimated.

szydlovsky avatar szydlovsky commented on June 10, 2024

Hello again - the fix will probably be merged in quite a while since polish May holidays start soon. But do not worry, if you need the fix badly, you can install Reanimated from @szydlovsky/rework-animatedComponent-tags branch.

from react-native-reanimated.

ElSeniorMikael avatar ElSeniorMikael commented on June 10, 2024

@szydlovsky is the version 3.10.0 fixing the problem with useAnimatedScrollhandler not firing ?

from react-native-reanimated.

khayym avatar khayym commented on June 10, 2024

I encountered the same issue on version 3.11.0, however, it worked fine on version 3.8.1

from react-native-reanimated.

efstathiosntonas avatar efstathiosntonas commented on June 10, 2024

hey guys, sorry for being a party pooper but I encountered an issue with the entire screen being detached when displaying an overlay after applying the patch. It's like the entire tree is gone, even the status bar is being hidden on both iOS and Android.

rn 0.73.8, reanimated 3.11.0 with the patch for 3.10.0 mentioned above, gesture-handler 2.16.2

I cannot share the code I'm using since it's rarther complex and it's a private repo. Let me know if we can communicate in another way. It seems that it does not like things being inside a ternary. If i remove the patch everything goes back to normal but ofcourse no scroll events on Flashlist.

The main concept is this:

  const panStyle = useAnimatedStyle<ViewStyle>(() => ({
    transform: [
      {
        translateY: translateY.value
      },
      {
        scale: scale.value
      }
    ]
  }));


  <Overlay>
  {children}
   {overlay === "whatever" ?
     <Animated.View pointerEvents="auto" style={styles.absoluteFill}>
        <Animated.View style={styles.absoluteFill}>
          <View style={styles.flex}>
            <TapGestureHandler
              maxDist={32}
              onHandlerStateChange={({ nativeEvent: { state } }) => {
                if (state === State.END) {
                  setOverlay("none");
                }
              }}
            >
              <Animated.View style={[styles.flex, panStyle]}>
              {some_other_stuff}
              </Animated.View>
  ...all other closing tags
  : null}
  </Overlay>

from react-native-reanimated.

szydlovsky avatar szydlovsky commented on June 10, 2024

Alternatively, there is a "final patch" as well: link

from react-native-reanimated.

losh11 avatar losh11 commented on June 10, 2024

Unfortunately useAnimatedScrollHandler doesn't seem to be firing for me with 3.11.0. I downgraded to 3.8.1 and it works. Would appreicate any assistance getting this to work.

const AnimatedFlashList = Animated.createAnimatedComponent(FlashList);
  const translationY = useSharedValue(0);
  const animatedHeaderStyle = useAnimatedStyle(() => {
    return {
      opacity: interpolate(translationY.value, [0, 100], [1, 0]),
    };
  });

const scrollHandler = useAnimatedScrollHandler(event => {
  translationY.value = event.contentOffset.y;
});

Standard stuff right?

from react-native-reanimated.

szydlovsky avatar szydlovsky commented on June 10, 2024

@losh11 Have you even tried reading the discussion above? The fix will be present, perhaps, in 3.12 version. Until then, you can either install latest nightly build or manually install a patch.

from react-native-reanimated.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.