GithubHelp home page GithubHelp logo

New versions of GTest use C++14 about srpc HOT 8 CLOSED

bkmgit avatar bkmgit commented on June 12, 2024 1
New versions of GTest use C++14

from srpc.

Comments (8)

holmes1412 avatar holmes1412 commented on June 12, 2024 1

@bkmgit It would be very appreciated if you could check that this commit works.

repo and branch: https://github.com/holmes1412/srpc/tree/cmake-3.26

from srpc.

bkmgit avatar bkmgit commented on June 12, 2024 1

Test seems to pass now on both Ubuntu and Fedora, maybe was an issue with GitHub:
https://github.com/bkmgit/srpc/actions/runs/4739468284/jobs/8414324683
Can update and rebase holmes1412#33 if helpful

from srpc.

holmes1412 avatar holmes1412 commented on June 12, 2024

Yes, I will add similar changes to fix this failing build.
Thanks.

from srpc.

bkmgit avatar bkmgit commented on June 12, 2024

谢谢 Based on holmes1412#33 it seems to run. When testing get

[----------] 1 test from ThriftHttp
[ RUN      ] ThriftHttp.unittest
/workflow/test/unittest.cc:165: Failure
Expected equality of these values:
  ctx->success()
    Which is: false
  true
[  FAILED  ] ThriftHttp.unittest (0 ms)
[----------] 1 test from ThriftHttp (0 ms total)

Other tests pass. This test passes locally for me though.

from srpc.

holmes1412 avatar holmes1412 commented on June 12, 2024

I can't figure out why it fails here. Could you post the failing link or some more informations?

from srpc.

bkmgit avatar bkmgit commented on June 12, 2024

https://github.com/bkmgit/srpc/actions/runs/4728630404/jobs/8390349320

Will continue debugging though if not immediately clear. Maybe setup, tests are not running on Ubuntu CI.

from srpc.

holmes1412 avatar holmes1412 commented on June 12, 2024

Thanks! I will try the ci actions like you do in the test branch and fix this failing UnitTest tomorrow.

from srpc.

holmes1412 avatar holmes1412 commented on June 12, 2024

Already merged~ Glad the test passed and thank you so much for the effort in checking the builds on Ubuntu and Fedora. It's helpful of course.
We'll deal with the PR #304 and make a released version.

from srpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.