Changing another object's state in a leave event still cause the object to run the now-previous state's step event about snowstate

[sohomsahaun]

1. What version of SnowState are you on?
2. You are saying fsm.get_current_state() in the "combat" state is showing "idle"?
3. "the squad variable provided in the obj_unit is undefined" - how is it provided?

[Paughton]

1. I am using the latest version of SnowState.
2. Yes, the string "idle" is copied to my clipboard before the error is displayed. The combat state for the obj_unit runs fine and doesn't produce any errors, until the squad object is destroyed.
3. The squad variable is provided when the object is created.

Here is how I create the unit object:

var player_squad = instance_create_layer(352, 288, "Map_Instances", obj_squad);
var player_squad_footman1 = instance_create_layer(0, 0, "Combat_Instances", obj_unit, {
	properties: footman_properties,
	squad: player_squad,
	col: 0,
	row: 1
});
player_squad.units[0][1] = player_squad_footman1;

Here was the error I was getting:

___________________________________________
############################################################################################
ERROR in
action number 1
of  Step Event0
for object obj_unit:

Unable to find instance for object index 100007
 at gml_Script_anon____struct___29_gml_Object_obj_unit_Create_0_468____struct___29_gml_Object_obj_unit_Create_0 (line 34) -               if (squad.owner_index != obj_game.unit_turns[obj_game.current_unit_turn_index].squad.owner_index) {
############################################################################################
gml_Script_anon____struct___29_gml_Object_obj_unit_Create_0_468____struct___29_gml_Object_obj_unit_Create_0 (line 34)
gml_Script_anon_SnowState_gml_GlobalScript_SnowState_9581_SnowState_gml_GlobalScript_SnowState (line 342) -               if (_args == undefined) return _func();
gml_Script_anon_SnowState_gml_GlobalScript_SnowState_9017_SnowState_gml_GlobalScript_SnowState (line 333) -               with (__owner) _pyramid(_func, _args);
gml_Script_anon_anon_SnowState_gml_GlobalScript_SnowState_4460_SnowState_gml_GlobalScript_SnowState_4576_anon_SnowState_gml_GlobalScript_SnowState_4460_SnowState_gml_GlobalScript_SnowState (line 162) -                      exec(event, undefined, _args);
gml_Object_obj_unit_Step_0 (line 3) - fsm.step();

One interesting thing to note was the error was started by fsm.step(); even though the instance was previously destroyed, and to my knowledge that shouldn't happen? The GML manual states:

Also, although the destroy event is performed, the instance is not immediately removed from the game, and it will continue to perform the code contained in the current event. Only when the current event is over will it be removed from the game.

[sohomsahaun]

From the given info, I'm unsure what the error is. But it doesn't look like a SnowState issue.
If you require GML assistance, I suggest asking in the GameMaker Discord server. We might need to see more of the codebase.
If you think it's a SnowState issue, please create a small project demonstrating the issue and send it to me.
Closing the issue for now.