The edit entity dialog allows to set illegal sizes about solarus-quest-editor

[christopho]

This is only possible from the edit entity dialog box. But still a bug, yes.

[Maxs1789]

I see three ways to solve this issue:

1. Check values when closing the dialog and show an appropriate error message.
2. Detect value changes then force the value to be a multiple of the base size:
   round(value / size) * size.
3. Use suffix of QSpinBox to display n * size where n >= 1, so the user cannot set arbitrary values.

I like the last one because it's very simple and gives informations about the base size.

[christopho]

Even if 1 was the behavior in the old editor, I'd say 2, like we do for the entity name: we silently change it it is already used.
3 is not an option to me.

[Maxs1789]

Ok, and what do you think about the idea to consider the ResizeMode in the edit entity dialog box?

• ResizeMode::NONE: disable two spin boxes.
• ResizeMode::HORIZONTAL_ONLY: disable the height spin box.
• ResizeMode::VERTICAL_ONLY: disable the width spin box.
• ResizeMode::SQUARE: detect when one of these spin boxes change and set the same value to the other one.
• ResizeMode::SINGLE_DIMENSION: the more complex, I don't know how to handle this case.
• ResizeMode::MULTI_DIMENSION_ONE: nothing to do.
• ResizeMode::MULTI_DIMENSION_ALL: nothing to do.

---

Also, what about the EntityModel::is_size_valid() method?

I think we should replace

if (width % 8 != 0 || height % 8 != 0) {
  return false;
}

by

if (width % base_size.width() != 0 || height % base_size.height() != 0) {
  return false;
}

It seems to me that width and height of the base_size are always multiple of 8.

[christopho]

Good ideas. For ResizeMode::SINGLE_DIMENSION: detect when one of these spin boxes change and set the base size to the other one.
Ok for the is_size_valid() change but first we need to check all callers.

[Maxs1789]

This is done for ResizeMode constraints!

But I realized that in this context, the modes SQUARE and SINGLE_DIMENSION aren't possible because they don't corresponds to a TilePatternRepeatMode.

Finally, we silently change values when closing the dialog or directly when editing spin boxes?

And for callers of the is_size_valid() I think it's ok.

---

Edit: I am wrong, the jumpers can be in ResizeMode::SQUARE and separators can be in ResizeMode::SINGLE_DIMENSION. I was thinking only about tiles ...

[Maxs1789]

All done!

Commited in master:

• 057a792
• f5265b4
• 5586e67
• e01c56e