Comments (3)
ryansolid
commented on May 5, 2024
For something that simple ternary operator is good. You only want the overhead of control flow when dealing with nested nodes/computed contexts. I have been generalizing the code between control flow and normal inserts the last couple releases and I probably am missing a couple cases in the tests. I will look at this, this evening and get you fix.
from solid.
ryansolid
commented on May 5, 2024
Yeah what I thought. Just introduced it yesterday. Missed a null check in one place. I've added new tests to dom-expressions. It is fixed in 0.7.5.
from solid.
bluenote10
commented on May 5, 2024
Great, thanks for the quick fix!
from solid.
Related Issues (20)
- Solid-js should diff values better in `insertExpression`
- Hard to move elements around using solid-js, insertExpression isn't fully DOM aware HOT 2
- [solid-js/html] `<Show>` inside `html` causes `TypeError: Cannot read properties of undefined (reading 'keyed')`
- [solid-js/html] `<Show>` in `html` template renders function source code to DOM
- Does not support camel case css property in jsx HOT 2
- Custom elements callbacks should untrack HOT 4
- [Bug?]: Hydration not fired with cascading deferStream HOT 1
- [JSX] [bug] `prop:foo={123}` compiles the value `123` into a string `"123"`.
- DevEx: Calling "`readSignal`" with arguments should throw HOT 7
- Stale read from <Show> under a transition HOT 5
- [Bug?]: multiple hydration errors with createResource HOT 1
- Top-level Anchor tags break out of the SVG namespace HOT 4
- Property 'xmlns:xlink' does not exist on type 'SvgSVGAttributes<SVGSVGElement>'. HOT 1
- When using a "computed key" in classList, a following `class` declaration overwrites the classes set by `classList` HOT 4
- When using typescript, solid-js depends on DOM elements, even outside of "solid-js/web" HOT 1
- Using `xlink:href` attribute with SVG `<use>` will throw type error, but this is legal in the specification HOT 4
- Unable to use in nextjs after build HOT 4
- Typo found in signal.ts? HOT 3
- Circular references in Stores trigger loss of proxying if non-trackable objects are referenced HOT 5
- I updated `vite-plugin-solid` and now namespaces merged with components are no longer allowed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solid.