Comments (3)
Ok I will give it a look, I admittedly am not terribly surprised given the way it value checks to decide the "key". So I assume this was happening before, but I will take a look. The old version was something I had Frankenstein'd, whereas the new version is actually almost a verbatim port of Surplus and S.js.
EDIT: hmm this did work in the old one. I'm going to see how it did.
from solid.
Ok, I figured it out. Turns out an optimization I was doing actual avoided a code path for these cases. I haven't hit any issues with sorting etc, but I have to imagine that there are some holes on duplicate listings on simple string values (and there always has been). I'm adding back the optimization which incidentally fixes this case, I'm just concerned there may be others.
Released in v0.9.2
from solid.
👍 Not sure if the only other issue I've noticed so far is related: It happens when using a mapping function of the form (s: string, i: number) => <div>{"is activated: " + (i == state.activeIndex)}</div>
. But I still have to reproduce that in a minimal test case.
from solid.
Related Issues (20)
- Typo found in signal.ts? HOT 3
- Circular references in Stores trigger loss of proxying if non-trackable objects are referenced HOT 5
- Changing the "data-type" of a `createStore` attribute causes referenced data to be modified HOT 1
- `value` parameter of `createEffect` is not passed to `on` as `prevValue` when `defer` is `true`. HOT 1
- using createStore setter function to update array results in argument is not iterable error HOT 3
- Solidjs is not working with bun.
- Laggy Performance HOT 4
- Unable to pass signal to child components HOT 1
- ReferenceError: XXX is not defined when using createResource HOT 3
- 2-way binding for computationally expensive effects
- `createResource` seems to fail to trigger fetcher when source signal changes HOT 1
- Why can't my code use context? HOT 9
- Setting properties to the unwrapped value of a store doesn't always propagate into the store HOT 14
- If a function wrapped in `action` throws some error it should be possible to `catch` it. HOT 1
- Isomorphic export with `solid-js/web` HOT 3
- Feature request: package entry point for reactive core HOT 1
- Trying to access fields of data from `createResource` throws error HOT 2
- Why the element between Shows is removed? HOT 4
- useTransition pending states should be isolated in different Suspense boundaries HOT 2
- 'reconcile' mutates array items HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solid.