GithubHelp home page GithubHelp logo

Comments (3)

ryansolid avatar ryansolid commented on May 5, 2024

Ok I will give it a look, I admittedly am not terribly surprised given the way it value checks to decide the "key". So I assume this was happening before, but I will take a look. The old version was something I had Frankenstein'd, whereas the new version is actually almost a verbatim port of Surplus and S.js.

EDIT: hmm this did work in the old one. I'm going to see how it did.

from solid.

ryansolid avatar ryansolid commented on May 5, 2024

Ok, I figured it out. Turns out an optimization I was doing actual avoided a code path for these cases. I haven't hit any issues with sorting etc, but I have to imagine that there are some holes on duplicate listings on simple string values (and there always has been). I'm adding back the optimization which incidentally fixes this case, I'm just concerned there may be others.

Released in v0.9.2

from solid.

bluenote10 avatar bluenote10 commented on May 5, 2024

👍 Not sure if the only other issue I've noticed so far is related: It happens when using a mapping function of the form (s: string, i: number) => <div>{"is activated: " + (i == state.activeIndex)}</div>. But I still have to reproduce that in a minimal test case.

from solid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.