Please update sonar.branch to sonar.branch.name about sonar-scanner-npm

[ilia-kebets-sonarsource]

Hello @ricochetbrown,

Could you clarify your request? I don't understand.

[ricochetbrown]

sonar-scanner-npm/test/unit/config.test.js

Line 255 in b6b4af2

'sonar.branch': 'dev',

SonarQube does not work with sonar.branch anymore. See this line in your test file. We need the SONAR_BRANCH env variable to update sonar.branch.name for us to specify branch names and use this with our Pull Requests for Nx on Azure Devops. Otherwise it just gets HEAD every time.

[saberduck]

@ricochetbrown how exactly does this value in the test file affect you? To me it looks like just a test fixture, we actually don't have any logic around this property