GithubHelp home page GithubHelp logo

Comments (5)

greg0ire avatar greg0ire commented on August 18, 2024 1

See symfony/symfony-docs#9886 not sure if we should do that for no services at all, or allow doing it for services relevant to the end user

from exporter.

greg0ire avatar greg0ire commented on August 18, 2024 1

@OskarStark please see https://github.com/symfony/symfony-docs/blob/master/bundles/best_practices.rst#services, apparently the best practice is exactly what is proposed here.

from exporter.

greg0ire avatar greg0ire commented on August 18, 2024 1

@Jerome1337 would you please make a pull request for this?

from exporter.

OskarStark avatar OskarStark commented on August 18, 2024

IMO its not a best practice to do that for a third party bundle, but I can be wrong

No need to do it in PHP, you can define an alias in your services.yaml file

from exporter.

soullivaneuh avatar soullivaneuh commented on August 18, 2024

IMO its not a best practice

Where did you see that? It's done on many bundles. And how will you provide auto-wiring without this method?

The only better thing to do here is to provide an interface.

from exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.