GithubHelp home page GithubHelp logo

Comments (2)

Ron2 avatar Ron2 commented on August 15, 2024

Thank you for reporting this. I can reproduce the problem in the latest release. It looks like this sample app never marks its document as "dirty" (modified) which is why the File -> Save menu command and the toolstrip icon are disabled. That's another mystery and maybe a separate bug as to why Ctrl+S still works! I'll look into this more tomorrow.

from atf.

Ron2 avatar Ron2 commented on August 15, 2024

I checked in a fix. Thanks again for reporting this.

The sample app had overridden the Dirty property in the base class DomDocument, but did not call the base class's OnDirtyChanged() when the Dirty property was changing. So, the DirtyChanged event wasn't being raised which eventually caused CommandService to not enable the Save command. Ctrl+S still worked because keyboard shortcuts cause the CommandService to double-check if the ICommandClient could do the command. The fix was to simplify the code -- there was no need to override the Dirty property; instead this sample app just needed to listen to the EditingContext's DirtyChanged event and update the document's dirty flag accordingly.

from atf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.