Import circular dependency error regarding restart module about sopht

[ilianasiriziba]

Hi @armantekinalp

In the latest version of the restart example, I fixed the order for imports. If you check that it imports utils first. I also run the example again and it is working fine.

[sy-cui]

Hi @ilianasiriziba .

You are right. At the moment most case files should be working. However, a simple way to recreate the issue is to have a new file with the following lines

import sopht.simulator as sps
import sopht.utils as spu

This will cause a circular import error because spu is imported within some sps files, while restart_sim also imports some of the sps objects.

I think a easy fix is to remove all references to flow simulator related types (or anything related to sps for that matter) within restart_sim.py, and return the current time from the function

def restart_simulation(
    # No flow_sim here
    ...
):
    ...
    curr_time = io.load(...)
    ...
    return curr_time

then in case files (restart_example.py, for example) correct the flow simulator time

time = restart_simulation(...)
flow_sim.time = time

This avoid import sps members inside an spu file. @ilianasiriziba do you want to try this an confirm if it works?

[ilianasiriziba]

Hi @sy-cui

Sure, I'll try this and let you know.