GithubHelp home page GithubHelp logo

Comments (9)

mathpaquette avatar mathpaquette commented on June 2, 2024 1

also vm2 has been deprecated by now. https://www.npmjs.com/package/vm2

from sorry-cypress.

mathpaquette avatar mathpaquette commented on June 2, 2024 1

#659 similar discussion

from sorry-cypress.

mathpaquette avatar mathpaquette commented on June 2, 2024 1

@agoldis do you mind if I revisit this by removing pm2 once and for all ?

from sorry-cypress.

agoldis avatar agoldis commented on June 2, 2024 1

@mathpaquette sure, just keep in mind that it allows the processes to run without restarts them manually on fatal crash

from sorry-cypress.

mathpaquette avatar mathpaquette commented on June 2, 2024 1

@ravichandra480 apparently just yarn upgrade pm2@latest just made it. gimme some time to build and test

from sorry-cypress.

ravichandra480 avatar ravichandra480 commented on June 2, 2024 1

Hi @mathpaquette Thanks for the quick help.

from sorry-cypress.

ravichandra480 avatar ravichandra480 commented on June 2, 2024

Hi @agoldis, I tried to update the PM2 version that has removed the dependency on VM2 5643#issuecomment-1682304269 This fixes the vulnerability in sorry cypress, Is it fine If I make a PR with updating PM2 version @agoldis ? This will unblock us. And @mathpaquette can continue his work removing PM2 dependency on original feature Remove pm2 manager from Director in Dockerfile.

from sorry-cypress.

mathpaquette avatar mathpaquette commented on June 2, 2024

vm2 has been removed by now

from sorry-cypress.

mathpaquette avatar mathpaquette commented on June 2, 2024

@ravichandra480 just request these freshly created docker images:

#32 pushing manifest for docker.io//sorry-cypress-dashboard:latest@sha256:76bad8f0951ef541280b063d9fd64d959b74d86fecb3a7514e1c1a31f0f579aa
#32 pushing manifest for docker.io/
/sorry-cypress-dashboard:latest@sha256:76bad8f0951ef541280b063d9fd64d959b74d86fecb3a7514e1c1a31f0f579aa 1.0s done

https://hub.docker.com/layers/agoldis/sorry-cypress-director/latest/images/sha256-8d4ea94405628c946a0ee51f3d2919677a0bb40a93bc54d58c05303fd15d3176?context=explore

etc..

from sorry-cypress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.