GithubHelp home page GithubHelp logo

Comments (12)

smnbbrv avatar smnbbrv commented on May 23, 2024 2

I close this I guess

from ngx-sortablejs.

BrainCrumbz avatar BrainCrumbz commented on May 23, 2024 1

Tried this workaround in v1.5.0-rc1 and it worked. Not sure if that also works with the version currently shipping with angular-sortablejs.

BTW, it seems like angular-sortablejs installed package holds a local node_modules subdirectory, with a local sortablejs directory too. Is that intentional? Shouldn't that be listed as a dependency or peerDependency, and let npm install it?

Uhm, tried uninstalling and installing again and that subdirectory went away. Please ignore, it must have been some local messing while debugging issue.

Cheers

from ngx-sortablejs.

smnbbrv avatar smnbbrv commented on May 23, 2024

Hi @BrainCrumbz

I'm not sure there is any difference for the browsers here... What's done in angular-sortablejs is just a directive which operates with the model, it listens to the same events as you would listen directly on sortablejs etc.

The only thing I can advice here is trying to debug the sortablejs original library files from the node_modules. That's how I usually solved things like this...

There is no automatic testing here, I can't really imagine how to correctly test the dragging behavior in different browsers automatically.

from ngx-sortablejs.

BrainCrumbz avatar BrainCrumbz commented on May 23, 2024

Hi @smnbbrv , thanks for clarifying (and excuse for late reply). To gain a better understanding, by any chance:

  1. do you know about a ready-made plunker with angular-sortablejs? That's just to avoid starting from scratch, and avoid any issue that might be related to our project

  2. do you have any pointer into sortablejs original source code, where to start debugging an issue like this?

Thanks in any case

from ngx-sortablejs.

smnbbrv avatar smnbbrv commented on May 23, 2024

Hi @BrainCrumbz

I didn't create any plunkr yet, would be good to have one.

Debugging sortablejs is hard. It has many fallbacks, browser related code etc. so the issue could be nearly at any line... I'm not strong at the original library, maybe ask @RubaXa to help you out

from ngx-sortablejs.

BrainCrumbz avatar BrainCrumbz commented on May 23, 2024

Tried putting up a plunker, starting from one of the latest angular + typescript seed plunkers. As for other npm modules, angular-sortable.js is referenced from unpkg.com.

In app.ts, as soon as SortablejsModule is added to @NgModule.imports array, the app breaks and console is not helping in understanding what goes wrong. If you want to have a look, here it is.

Anyway, this of plunker is a side issue. Main point is still trying to reproduce the issue with a seed project.

from ngx-sortablejs.

smnbbrv avatar smnbbrv commented on May 23, 2024

@BrainCrumbz I couldn't have noticed that you use [email protected] in the plunkr which is known for many issues. Have you tried to override it with [email protected]?

from ngx-sortablejs.

BrainCrumbz avatar BrainCrumbz commented on May 23, 2024

Hi there, thanks for pointing that out, will give that a spin right away. That version is the one I found when looking into angular-sortablejs own dependencies in its package.json. So, if I got it right, basically is the one our project is including because of angular-sortablejs.

from ngx-sortablejs.

BrainCrumbz avatar BrainCrumbz commented on May 23, 2024

No luck, runtime error shows up as soon as angular-sortablejs module is added to import list:

Error: (SystemJS) XHR error (500 Internal Server Error) loading https://unpkg.com/[email protected]/dist/index.js/index.js
patchProperty/desc.set/wrapFn@https://unpkg.com/[email protected]/dist/zone.js:628:26
ZoneDelegate.prototype.invokeTask@https://unpkg.com/[email protected]/dist/zone.js:225:23
Zone.prototype.runTask@https://unpkg.com/[email protected]/dist/zone.js:125:28
ZoneTask/this.invoke@https://unpkg.com/[email protected]/dist/zone.js:293:28

Error loading https://unpkg.com/[email protected]/dist/index.js/index.js as "angular-sortablejs" from https://run.plnkr.co/yPl1nTMGWBPrEANT/src/app.ts

from ngx-sortablejs.

smnbbrv avatar smnbbrv commented on May 23, 2024

@BrainCrumbz no, I mean did you try it on your local machine to fix the original issue? :)

Sorry for misleading

from ngx-sortablejs.

smnbbrv avatar smnbbrv commented on May 23, 2024

@BrainCrumbz the version ^1.4.2 is shipped with angular-sortablejs, so whenever non-rc sortablejs version is released everybody will get a modern one.

from ngx-sortablejs.

waspar avatar waspar commented on May 23, 2024

Still actual for me the version 1.7.0

from ngx-sortablejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.