error: _minhash.hh: No such file or directory about sourmash

[ctb]

Iiiiinteresting. This works on my Mac and on Linux (Debian) with gcc 4. Wonder what's different? I think the fix will be to include the sourmash_lib directory in includes in setup.py, but generally I would expect a ``` #include "xxx.hh" ``` to look in the same directory, no?

[ctb]

See #7. Let me know if it works for you!

[sjackman]

I'm not able to reproduce this error outside of pip install sourmash. Running cd sourmash && python setup.py install works as expected. Also, cd sourmash && pip install . works as expected. Running pip install sourmash gives the error message as above. Any thoughts on how I can reproduce this error and test this PR?

[ctb]

Try cloning and doing pip install ./sourmash - I will test also.

Titus Brown, [email protected]

On Jun 7, 2016, at 2:39 PM, Shaun Jackman [email protected] wrote:

I'm not able to reproduce this error outside of pip install sourmash. Running cd sourmash && python setup.py install works as expected. Also, cd sourmash && pip install . works as expected. Running pip install sourmash gives the error message as above. Any thoughts on how I can reproduce this error and test this PR?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

[sjackman]

pip install ./sourmash succeeds as well.

[sjackman]

curl -L https://github.com/dib-lab/sourmash/archive/v0.3.tar.gz | tar xz && pip install sourmash-0.3/

succeeds as well.

[ctb]

could you try ``` pip install git+https://github.com/dib-lab/sourmash.git@master ``` at your leisure? thx!

[sjackman]

Success.

$ pip install git+https://github.com/dib-lab/sourmash.git@master
Collecting git+https://github.com/dib-lab/sourmash.git@master
  Cloning https://github.com/dib-lab/sourmash.git (to master) to /tmp/pip-Ehq8V7-build
Requirement already satisfied (use --upgrade to upgrade): screed>=0.9 in /gsc/btl/linuxbrew/lib/python2.7/site-packages (from sourmash==0.3)
Requirement already satisfied (use --upgrade to upgrade): PyYAML>=3.11 in /gsc/btl/linuxbrew/lib/python2.7/site-packages (from sourmash==0.3)
Requirement already satisfied (use --upgrade to upgrade): bz2file in /gsc/btl/linuxbrew/lib/python2.7/site-packages (from screed>=0.9->sourmash==0.3)
Installing collected packages: sourmash
  Running setup.py install for sourmash ... done
Successfully installed sourmash-0.3

[ctb]

great, thank you!

[sjackman]

Any idea why curl -L https://github.com/dib-lab/sourmash/archive/v0.3.tar.gz | tar xz && pip install sourmash-0.3/ worked but pip install sourmash did not?

[sjackman]

In any case, thanks for the help troubleshooting.

[ctb]

On Wed, Jun 08, 2016 at 02:37:18PM -0700, Shaun Jackman wrote:

Any idea why curl -L https://github.com/dib-lab/sourmash/archive/v0.3.tar.gz | tar xz && pip install sourmash-0.3/ worked but pip install sourmash did not?

nope :). my guess is that the cwd was set differently.

[ctb]

For future reference, this was actually caused by a failure to include the .hh files in the MANIFEST.in file.

[ctb]

See https://stackoverflow.com/questions/1612733/including-non-python-files-with-setup-py for general info.