GithubHelp home page GithubHelp logo

Comments (10)

slyness avatar slyness commented on May 6, 2024

Awesome. I will review this week.

from postgresql.

gsaslis avatar gsaslis commented on May 6, 2024

@slyness : sorry for not replying earlier..
I think I should probably close #221, (no branch created, etc.) and open a new one for each of the two commits which i inadvertently included in the same PR.. what do you think?

from postgresql.

gsaslis avatar gsaslis commented on May 6, 2024

also, as per the contrib guide ( https://github.com/hw-cookbooks/postgresql/blob/develop/CONTRIBUTING.md ) I'm trying to run the tests (and then write some more) but I keep getting "No Chef resources found"... any pointers as to what i might be doing wrong / missing?

from postgresql.

gsaslis avatar gsaslis commented on May 6, 2024

could we have this merged in guys?

please feel free to let me know if there's something extra I should be doing... ; )

from postgresql.

slyness avatar slyness commented on May 6, 2024

We are way behind right now on reviewing a merging items in this repository. I hope to spend some time on that today. Thanks for the continued feedback and PRs.

from postgresql.

gsaslis avatar gsaslis commented on May 6, 2024

Sounds good!! Anything I can do to help, please don't hesitate to ask... ; )


Giorgos Saslis

On Fri, May 22, 2015 at 7:57 PM, Aaron Baer [email protected]
wrote:

We are way behind right now on reviewing a merging items in this repository. I hope to spend some time on that today. Thanks for the continued feedback and PRs.

Reply to this email directly or view it on GitHub:
#220 (comment)

from postgresql.

gsaslis avatar gsaslis commented on May 6, 2024

@slyness I believe the initdb that was added in your bf7fd29 commit for SUSE systems should not be there.
This is definitely true for Opensuse 13.1 and 13.2, but I am not sure if there are some other suse-family systems you had in mind?

In fact, the reason I had originally opened this issue was because of a typo in https://github.com/hw-cookbooks/postgresql/blob/v3.4.14/recipes/server_redhat.rb#82, causing it to be executed, when it shouldn't have been invoked at all.

Please let me know and I'll be happy to open a relevant PR.

from postgresql.

damacus avatar damacus commented on May 6, 2024

@gsaslis if this is still relevant, we'd love a PR for this feature.

from postgresql.

damacus avatar damacus commented on May 6, 2024

I'm going to close this issue down now.

If anyone would like to add OpenSUSE support to the cookbook, that would be great!

from postgresql.

lock avatar lock commented on May 6, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from postgresql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.