Spaces in notebook filename about nbsphinx

[mgeier]

Thanks for the report!

Does #68 work for you?

[senyai]

Yes it does! I tried User Guide - Basics.ipynb and User_Guide - Basics.ipynb at the same time and the images are at right places.

[mgeier]

Thanks for testing this!

The image file name also contains the cell number and the number within the cell output (there may be several outputs per cell).

I guess if you have an image in the same cell in both of the files in your edge case, it will cease to work, right?

[senyai]

You guessed it right. I didn't understood the importance of cell numbers. Luckily, people don't name files that way, so nobody will blame you for this commit.

[mgeier]

Actually, I wanted to avoid this case, but I don't know how.

I tried to use %-encoding, like it's normally done in URLs, but this didn't work for some reason. Probably it's even a bug in Sphinx, because source names that contain %AB (where A and B are any hexadecimal characters) cannot be shown in the browser because Sphinx doesn't seem to escape those % signs.

If you know a way how to avoid this edge case, speak up!

Anyway, as you say, let's hope that people don't name their files in such a strange way ...

[mgeier]

I'm actually not sure if that's a bug or a feature of Sphinx, so I created an issue there: sphinx-doc/sphinx#3097.