Comments (2)
Indeed, my recommendation in the meantime is to always work DateTimeImmutable
instead of DateTime
which is way safer as it avoids this kind of mess by creating copy instead of modifying the current object.
For the record, DateTime
still exist in PHP just for backward compatibility. It is a design mistake, And date and time should always be represented in an immutable way.
Because actually mutable date-time makes no sense, you can't change a date. When $appointment->startDate
changes, it's not semantically correct to say "Monday 8AM NY time becomes something else", no "Monday 8AM NY time" won't change, it's still the same for everybody, only your appointment change, and you actually set startDate to an other value.
$monday8AM = new DateTime('2022-07-25 08:00 America/New_York');
$appointment1->startDate = $monday8AM;
$appointment2->startDate = $monday8AM;
$appointment1->startDate->modify('2022-07-26 10:00 America/New_York');
You can see in this example that using DateTime
does not properly reflect reality and lead to mistake.
Here $monday8AM
get modified and $appointment2->startDate
is affected by changing $appointment1->startDate
.
Also there is no mutation of $appointment1
in the code.
DateTimeImmutable
is a way better way to reflect the reality of date/time manipulation and lead to less mistakes:
$monday8AM = new DateTimeImmutable('2022-07-25 08:00 America/New_York');
$appointment1->startDate = $monday8AM;
$appointment2->startDate = $monday8AM;
$appointment1->startDate = $appointment1->startDate->modify('2022-07-26 10:00 America/New_York');
If we call modify
(or setTimezone
) it returns a new instance.
So here we don't mutate $monday8AM
, $appointment2->startDate
is unaffected and the mutation of $appointment1
becomes explicit.
Of course we should still fix support for DateTime
in spatie/opening-hours
from opening-hours.
Fixed in 2.11.3
from opening-hours.
Related Issues (20)
- several advanced features HOT 4
- Github URL update HOT 2
- [Question/Feature Request] How to get all days of the current week including days resulting from exceptions? HOT 3
- [Bug] nextOpen calculates the wrong date for a regular day with exceptions HOT 3
- Free time slots during the day ? HOT 1
- nextOpen not respecting timezone HOT 2
- Timezone not working in currentOpenRange HOT 2
- I want to add schedule for specific date HOT 1
- Locale? HOT 1
- GitHub repository link not working HOT 2
- Support for holidays HOT 5
- Overflow support does not seem to work for createAndMergeOverlappingRanges HOT 2
- diffInOpenMinutes() does not work if only one day is configured as open HOT 6
- Date period in exceptions or start and end date for a set of days of the week in regular time HOT 4
- Exceptions with date ranges HOT 5
- [Feature request] createFromStructuredData method
- How to destroy OpeningHours object or update it ? HOT 1
- How to create an exception using datetime with seconds HOT 2
- Adding seconds precision to exceptions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opening-hours.