GithubHelp home page GithubHelp logo

Comments (10)

edonadei avatar edonadei commented on September 28, 2024 1

In regards of the document about minimum requirements provided by NTIA, it's written page 12 that Known Unknowns must be explicitly identified and that it's better to avoid erroneous assumptions. IMHO the NOASSERTION of the SPDX spec fits that definition.

from ntia-conformance-checker.

lumjjb avatar lumjjb commented on September 28, 2024 1

Given that most SBOMs today don't meet the requirement, maybe we could have a mode or additional output for a score to show % of packages that are compliant (similar to how the sbom scorecards does it)

from ntia-conformance-checker.

goneall avatar goneall commented on September 28, 2024 1

Agree - we could add this to a major release along with the other breaking change.

from ntia-conformance-checker.

jspeed-meyers avatar jspeed-meyers commented on September 28, 2024

@edonadei, thank you for filing this issue.

I'm open to your interpretation. @goneall or @kestewart, thoughts?

from ntia-conformance-checker.

goneall avatar goneall commented on September 28, 2024

This is similar to #125 where we decided NOASSERTION would not be EO compliant.

from ntia-conformance-checker.

jspeed-meyers avatar jspeed-meyers commented on September 28, 2024

Okay, to clarify for myself the questions under discussion here.

One question seems to be:

If a package has:

  1. a blank supplier field or a supplier field with a NOASSERTION value AND
  2. a blank originator field or an originator field with a NOASSERTION value

then is that package (and by, extension, that SBOM) not NTIA minimum elements compliant?

To the best of my understanding, it is not minimum elements compliant. Does anyone disagree with that understanding?

The next question is:

If a package has:

  1. a blank supplier field or a supplier field with a NOASSERTION value

then is that package (and by, extension, that SBOM) not NTIA minimum elements compliant?

Reading the code comments, the comments suggest that either the package supplier or the package originator fields satisfy the NTIA minimum elements "supplier" field. But when I read the SPDX documentation on mapping SPDX field to NTIA, it appears that only the SPDX package supplier field maps to the NTIA minimum elements supplier field. So, to me, then the code should be changed.

Hmmm. Thoughts?

from ntia-conformance-checker.

jspeed-meyers avatar jspeed-meyers commented on September 28, 2024

@lumjjb -- I'd be supportive of that as additional JSON output.

from ntia-conformance-checker.

jspeed-meyers avatar jspeed-meyers commented on September 28, 2024

Friendly ping to @edonadei. Thoughts on my September 13th response?

from ntia-conformance-checker.

jspeed-meyers avatar jspeed-meyers commented on September 28, 2024

@goneall: How would you like to proceed? This could be a candidate for a breaking change.

from ntia-conformance-checker.

jspeed-meyers avatar jspeed-meyers commented on September 28, 2024

Okay, I'll open a PR for review soon. This might require a little tinkering with the test suite too.

from ntia-conformance-checker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.