GithubHelp home page GithubHelp logo

Comments (4)

nicoweidner avatar nicoweidner commented on September 27, 2024 1

The fork was last updated in August, so is quite out of date by now (since a lot of things happened in the meantime). I looked at the fork and it seemed the only addition it has compared to upstream is a PR that was rejected in tools-python. See this comment on the PR for the main reasons. The author never came back and replied.

In general, I would advise to use upstream, of course. And I also think that the changes from the PR mentioned above are not desirable. But if ntia-conformance-checker really relies on those changes, switching to upstream may cause some issues.

To save you some time: The main change from the PR was that for any given input file, all parsers (for the various formats) attempt to parse the file, regardless of its ending. This covers cases where a file was given the wrong ending (e.g. a yaml file that has a .json ending). I prefer to throw that back as a user error, though, and I would be surprised if it's important for the conformance checker to include this functionality.

from ntia-conformance-checker.

goneall avatar goneall commented on September 27, 2024

The only open question: Should this project switch to the upstream before the upstream accepts three commits from @linynjosh's fork? Or should the project switch to the upstream and, in the meantime, try to merge those changes? (Assuming those changes haven't been submitted and merged in the past sometime.)

@nicoweidner @meretp @armintaenzertng Any suggestions?

from ntia-conformance-checker.

goneall avatar goneall commented on September 27, 2024

Thanks @nicoweidner for the analysis. From the description of the additional commits, it doesn't sound like it is essential to the operation of the conformance checker and we can probably just switch to the upstream.

from ntia-conformance-checker.

jspeed-meyers avatar jspeed-meyers commented on September 27, 2024

Roger. Thank you, @nicoweidner!

I'll put in a PR to switch to the upstream.

from ntia-conformance-checker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.