Comments (4)
The fork was last updated in August, so is quite out of date by now (since a lot of things happened in the meantime). I looked at the fork and it seemed the only addition it has compared to upstream is a PR that was rejected in tools-python
. See this comment on the PR for the main reasons. The author never came back and replied.
In general, I would advise to use upstream, of course. And I also think that the changes from the PR mentioned above are not desirable. But if ntia-conformance-checker
really relies on those changes, switching to upstream may cause some issues.
To save you some time: The main change from the PR was that for any given input file, all parsers (for the various formats) attempt to parse the file, regardless of its ending. This covers cases where a file was given the wrong ending (e.g. a yaml file that has a .json ending). I prefer to throw that back as a user error, though, and I would be surprised if it's important for the conformance checker to include this functionality.
from ntia-conformance-checker.
The only open question: Should this project switch to the upstream before the upstream accepts three commits from @linynjosh's fork? Or should the project switch to the upstream and, in the meantime, try to merge those changes? (Assuming those changes haven't been submitted and merged in the past sometime.)
@nicoweidner @meretp @armintaenzertng Any suggestions?
from ntia-conformance-checker.
Thanks @nicoweidner for the analysis. From the description of the additional commits, it doesn't sound like it is essential to the operation of the conformance checker and we can probably just switch to the upstream.
from ntia-conformance-checker.
Roger. Thank you, @nicoweidner!
I'll put in a PR to switch to the upstream.
from ntia-conformance-checker.
Related Issues (20)
- ntia-checker fails for files under fileName must not be an absolute path HOT 5
- ntia-checker --version does not give the version HOT 4
- Bug: test the presence of the --file argument if another argument is present HOT 1
- Syntax of the short arguments HOT 3
- Package supplier and originator fields, is having both as NOASSERTION is not EO compliant? HOT 10
- Cut a v1.0.0 Release? HOT 1
- Move Python Support From 3.8 to 3.9
- licenseId is not a case-sensitive as per spdx ,but this tool follows case-sensitve? HOT 13
- get_components_without_* functions shold return the SPDX ID of the component if there is one HOT 9
- Add Black and Pylint to Contributing Doc
- Getting confused about tri licensed package HOT 6
- Spelling: Minimum vs mininum HOT 10
- What GitHub Badges (or Practices) Do You Want This Repo to Have? HOT 1
- [Docs] Add Documentation on Pre-Built Container Applications of `ntia-conformance-checker` HOT 1
- `check_dependency_relationships` Function Does Not Match SPDX Minimum Elements Definition of "Relationship" Field HOT 1
- Should .idea Folder and Contents Be Deleted?
- Cut v2.0.0 Release
- Cut New Release - v2.0.0 HOT 3
- check_dependency_relationships test does not seem correct HOT 17
- Add a OpenSSF Scorecard GitHub Badge to Repo README
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ntia-conformance-checker.