GithubHelp home page GithubHelp logo

Address TODO comment in code: FactoryRegistration.Resolve should add the created object into the pool of created objects about bodi HOT 2 CLOSED

specflowoss avatar specflowoss commented on June 3, 2024
Address TODO comment in code: FactoryRegistration.Resolve should add the created object into the pool of created objects

from bodi.

Comments (2)

craigfowler avatar craigfowler commented on June 3, 2024

In fact - it turns out that this is not a problem after all. I see no reason that the resolved instance needs to be added to any kind of pool. In line with the test at BoDi.Tests.RegisterFactoryDelegateTests.ShouldReturnTheSameIfResolvedTwice it is clear that the instance is already cached and reused when resolving for a second time. I instead propose removing this comment (line 404 of BoDi.cs):

//TODO: store result object in pool?

from bodi.

gasparnagy avatar gasparnagy commented on June 3, 2024

removed. thx.

from bodi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.