libpurple: Support for PURPLE_MESSAGE_IMAGES about spectrum2

[thundergreen]

I agree with the third possibility :)

[vitalyster]

I'm voting for XEP-0060 with fallback to 3)

[rigid]

@vitalyster 👍 for your option.
although anything is better than nothing here...

[jankaluza]

Just some implementation details for this bug. We have to check the message from libpurple for <img id="foo"> or <img id='bar'>, fetch the image from imgstore and store it, remove the id and use the right src to point to the right image. Then generate plaintext part of the message to replace img with a link and xhtml-im part of the message with the image.

[kousu]

I need to hijack this thread for a moment: does Spectrum still work with Facebook? How is that possible? I have libpurple 2.10.12-1 under my Pidgin and it fails at login with:

<features xmlns='http://etherx.jabber.org/streams'>
    <starttls xmlns='urn:ietf:params:xml:ns:xmpp-tls'/>
    <mechanisms xmlns='urn:ietf:params:xml:ns:xmpp-sasl'>
        <mechanism>X-FACEBOOK-PLATFORM</mechanism>
        <mechanism>PLAIN</mechanism>
    </mechanisms>
</features>
<starttls xmlns='urn:ietf:params:xml:ns:xmpp-tls'/>
<proceed xmlns='urn:ietf:params:xml:ns:xmpp-tls'/>
<features xmlns='http://etherx.jabber.org/streams'>
    <mechanisms xmlns='urn:ietf:params:xml:ns:xmpp-sasl'>
        <mechanism>X-FACEBOOK-PLATFORM</mechanism>
        <mechanism>PLAIN</mechanism>
    </mechanisms>
</features>
<auth xmlns='urn:ietf:params:xml:ns:xmpp-sasl' mechanism='PLAIN' client-uses-full-bind-result='true'>XXXXXXXXXXXXXXXXXXXXXXXXXX=</auth>
<failure xmlns='urn:ietf:params:xml:ns:xmpp-sasl'>
    <not-authorized/>
    <text>plain login failed</text>
</failure>

I thought Facebook turned off XMPP in favour of Messenger four months ago, but you say you just tested this this week. Is Spectrum using a secretly updated libpurple?

[vitalyster]

Spectrum uses prpl-facebook

[kousu]

That's https://github.com/jgeboski/purple-facebook? Thank you for the clue, and for fighting the walled gardening.