GithubHelp home page GithubHelp logo

Comments (14)

bob7l avatar bob7l commented on August 17, 2024

Unless I'm misunderstanding, I can't reproduce this issue on 1.8.9 or 1.20.4 using build 1804.

https://i.gyazo.com/4bf677b5469aae03f8debf4064f9bd8b.png

from bungeecord.

andreasdc avatar andreasdc commented on August 17, 2024

I was testing on 1.20.2 client, but I dont think thats the case. I was testing with older bungee and I didnt have it, I will test it again later.

from bungeecord.

Janmm14 avatar Janmm14 commented on August 17, 2024

Are these things are sent by bungee plugins or sent by the spigot server in both your setups?

from bungeecord.

andreasdc avatar andreasdc commented on August 17, 2024

They are sent by BungeeTabListPlus by bungee.

from bungeecord.

Janmm14 avatar Janmm14 commented on August 17, 2024

They are sent by BungeeTabListPlus by bungee.

Maybe @bob7l is using different bungee plugin or using a spigot plugin?

Either way it'd be best if you could do check whether that commit is actually the problem.

Could you provide one example source string which is incorrectly un-bolded? Or is just a simple §lAbcd also getting un-bolded?

from bungeecord.

andreasdc avatar andreasdc commented on August 17, 2024

They are sent by BungeeTabListPlus by bungee.

Maybe @bob7l is using different bungee plugin or using a spigot plugin?

Either way it'd be best if you could do check whether that commit is actually the problem.

Could you provide one example source string which is incorrectly un-bolded? Or is just a simple §lAbcd also getting un-bolded?

All strings are unbolded and don't have strikethrough. Let me try again.

from bungeecord.

andreasdc avatar andreasdc commented on August 17, 2024

This commit broke it...
231024b

from bungeecord.

md-5 avatar md-5 commented on August 17, 2024

Pretty sure that commit fixed an issue basically the same as what this ticket describes

from bungeecord.

andreasdc avatar andreasdc commented on August 17, 2024

This build works https://ci.md-5.net/job/BungeeCord/1776/
and this doesn't work https://ci.md-5.net/job/BungeeCord/1777/
Earlier I didn't have any issues with objects components, maybe it's a small mistake or something.
When I was debugging I think forcing that boolean made everything bold, so I think the issue is there.

from bungeecord.

bob7l avatar bob7l commented on August 17, 2024

Anyone else able to reproduce this?

I just tried BungeeTabListPlus on Bungee alone, and even BungeeTabListPlus on Spigot alone and still can't reproduce it. Used a combination of hex colors, strikethrough, bold, etc. Works fine.

@andreasdc Maybe you should add some debug code in Bungee to outprint the JSON string before it's deserialized so we can see exactly what's being read

from bungeecord.

andreasdc avatar andreasdc commented on August 17, 2024

I think it gets to check '"true"', then it doesn't see it as boolean. Other objects are just 'true' and they are boolean.

from bungeecord.

md-5 avatar md-5 commented on August 17, 2024

I guess .getAsBoolean() used to parse string to Boolean.

I think whatever is writing a boolean as a string is wrong, but bungee could be more relaxed I guess

from bungeecord.

Janmm14 avatar Janmm14 commented on August 17, 2024

@andreasdc I think your BungeeTablistPlus version is from before jan 20 2024, because thats where they fixed this: CodeCrafter47/TabOverlayCommon@af98309

from bungeecord.

andreasdc avatar andreasdc commented on August 17, 2024

Yup, I have the old version, didn't see that update. Thanks for your finding!

from bungeecord.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.