ERR wrong number of arguments for 'hset' command about split

[Adre]

Thanks for the help @andrehjr - loving your work!

[andrehjr]

Hi @Adre 🙌 Thanks for bringing this out.

Which redis version are you currently using? HMSET was deprecated on redis 4.0, and HSET will work with multiple arguments.

But as we're still supporting Redis < 4.0 I guess that should change to hmset. I can fix that and release a new version later today.

[Adre]

Hi @andrehjr - no problem!

We're using redis 4.2.5, which worked fine with split 3.4.1, but presents the issue after updating to split 4.0.0.pre

Don't forget, split 4.0.0.pre already requires redis >= 4.2 so I'm unable to test this against older versions of redis 😬

[andrehjr]

Hi @Adre! Sorry for the confusion.

I meant the redis server version, not the gem. For example If you run Redis.new.info["redis_version"].

https://redis.io/commands/hset accepts multiple args after 4.0 :)

The fix should be easy enough. Do you want to submit a PR for it? Should be basically change hset -> hmset at that point.

[Adre]

Oh, I see! 😆

You're absolutely right, turns out we're using Redis 3.2 in development, although we're actually using 5.0 in production. Looks like we need to update our development environment in this case to get parity, which should solve my particular problem.

I'm happy to put in a PR as you suggested if you're committed to supporting Redis <4.0, but as far as I can tell from the Redis release cycle page these versions are no longer maintained/supported?

[andrehjr]

Awesome! I've already pushed #659 to keep compatibility. Just in case someone is still using Redis < 4.

But in the future, we may drop that support if it turns out to be difficult to maintain. 🙌