GithubHelp home page GithubHelp logo

Comments (3)

gotwarlost avatar gotwarlost commented on June 9, 2024

You could make the counter argument.

If both are present, the project is likely transitioning from kubectl to qbec

I think as long as there are 2 annotations potentially in conflict, picking any one will always cause some case to fail.

I think what we need is the ability for qbec to use kubectl annotations when configured for a qbec app. That is, a flag in the qbec spec that says:

   impersonateKubectl: true

and if this is set qbec always writes a kubectl.kubernetes.io/last-applied-configuration annotation instead of the qbec one.

qbec already has the logic to read its own annotation and then kubectl's,. This is preserved as before.

For brand-new projects everything works the same except that qbec is writing the kubectl annotation and reading (as a 2 step process since the qbec version won't exist) it.

qbec should also have the logic to remove any qbec annotation that was present in the object when the project says it wants to impersonate kubectl and remove it going forward.

For a project that wants to transition to this, we need to document the migration process. This is, roughly,

  • do not add the flag, apply using qbec one time such that the qbec annotation is the latest version
  • add the flag and re-apply
  • this will cause qbec to compute diffs based on its annotation, delete it and use the kubectl version on apply so that subsequent runs are clean

from qbec.

kvaps avatar kvaps commented on June 9, 2024

I think as long as there are 2 annotations potentially in conflict, picking any one will always cause some case to fail.

That's not fully true, as the only case when both of them are existing is when kubectl is used over qbec. The purposed change should not break anything but it will consider the changes made by hand via kubectl.

I think what we need is the ability for qbec to use kubectl annotations when configured for a qbec app. That is, a flag in the qbec spec that says:

impersonateKubectl: true

and if this is set qbec always writes a kubectl.kubernetes.io/last-applied-configuration annotation instead of the qbec one.

What the reason we need qbec annotation then why not always using kubectl annotation instead?

from qbec.

kvaps avatar kvaps commented on June 9, 2024

@gotwarlost do you want to generate and write kubectl.kubernetes.io/last-applied-configuration annotation by qbec, right?
It would need some additional modifications in method as kubectl applies the namespace name there.

from qbec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.