Modular Input - textInNode throwing exception when input string is empty about splunk-sdk-java

[shakeelmohamed]

Hi @segfault-, thanks for you note. Feel free to open a pull request if there's a specific change you'd like to see

[segfault-]

my formatting didn't go thru, i just added a child!=null check

[bparmar-splunk]

Hi @segfault-,
We have checked the usage of XmlUtil.textInNode method in entire SDK code, and has found that null checks are implemented where this method is called.
We have also executed Validation test, but could not encounter this issue.

We would recommend to update SDK version to 1.7.1 and make use of JDK 1.8 & maven build, as we have migrated from Ant to Maven.

Please let us know, if you still face any issue, along with details to reproduce.

[jrobins04]

Hi @bparmar-splunk,

I am able to reproduce this using v1.9.1. This issue happens when the user provides no value for a modular input parameter.
https://github.com/splunk/splunk-sdk-java/blob/master/splunk/src/main/java/com/splunk/modularinput/XmlUtil.java textInNode() line number 38:

static String textInNode(Node node, String errorMessage) throws MalformedDataException {
        Node child = node.getFirstChild();
        if (child.getNodeType() != Node.TEXT_NODE) {
            throw new MalformedDataException(errorMessage);
        } else {
            return ((Text)child).getData();
        }
    }

Here no null check is performed for the child variable. In case when the modular input parameter has no value, child will be null and child.getNodeType() leads to null pointer.

Please let me know if you need any other information regarding this issue.