GithubHelp home page GithubHelp logo

Comments (8)

timcharper avatar timcharper commented on June 17, 2024

wow, good find! I will get this applied immediately.

from spork.

Milhouse avatar Milhouse commented on June 17, 2024

FYI, I'd forgotten that another fork had a commit to fix this issue for 1.8.7: http://github.com/pietervisser/spork/commit/c0c0f2b7ccaeb2dcfcd277aa736d87e63621a04b

from spork.

timcharper avatar timcharper commented on June 17, 2024

Awesome. Which solution do you like better?

from spork.

Milhouse avatar Milhouse commented on June 17, 2024

Honestly, I didn't examine them that closely. I'll take a closer look later.

from spork.

Milhouse avatar Milhouse commented on June 17, 2024

Since both ways work, I'd stick with the shorter one. BTW, cbaclig, thanks. I noticed the same problem when running a test in The Rspec Book in 25.2 when testing an Application controller to handle an error, but hadn't traced it back to the source.

from spork.

timcharper avatar timcharper commented on June 17, 2024

Agreed

from spork.

timcharper avatar timcharper commented on June 17, 2024

(thank you for looking at them :-))

And cbaclig, again, thank you for the patch.

from spork.

cbaclig avatar cbaclig commented on June 17, 2024

No problem. I should be the one thanking you guys for the work you've done so far!

from spork.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.