Regression between version 1.6.1 and 1.6.2,1.6.3,1.6.4 about spotbugs-gradle-plugin

[pacey]

https://github.com/pacey/spotbugs-example

Bumping the plugin version to 1.6.2 in the build.gradle file will cause SpotBugs to show issues, where version 1.6.1 does not.

[KengoTODA]

Hi, could you try to create Minimal, Complete, and Verifiable example? For now we have no information to reproduce your problem.

[pacey]

I'll try and find time today to throw an example project together

[KengoTODA]

With the following patch, I could find a SE_NO_SERIALVERSIONID in test case.

com.github.pacey.SampleTest$__spock_feature_0_1_closure1 is Serializable; consider declaring a serialVersionUID

diff --git a/build.gradle b/build.gradle
index 784a0ab..c1e8e6a 100644
--- a/build.gradle
+++ b/build.gradle
@@ -3,7 +3,7 @@ import com.github.spotbugs.SpotBugsTask
 plugins {
     id 'java'
     id 'groovy'
-    id "com.github.spotbugs" version "1.6.1"
+    id "com.github.spotbugs" version "1.6.4"
 }
 
 group 'com.github.pacey'

[KengoTODA]

I'm sure that it's not problem in spotbugs core, because following patch doesn't reproduce reported issue:

diff --git a/build.gradle b/build.gradle
index 784a0ab..d351f19 100644
--- a/build.gradle
+++ b/build.gradle
@@ -28,4 +28,8 @@ tasks.withType(SpotBugsTask) {
         html.enabled = true
         xml.enabled = false
     }
-}
\ No newline at end of file
+}
+
+spotbugs {
+  toolVersion = '3.1.7'
+}

So problem should exist in gradle plugin itself. I will check these changes between 1.6.1 and 1.6.2.

[KengoTODA]

@pacey in your environment, can you find other issues?

If we can find only SE_NO_SERIALVERSIONID, it could be not bug but expected change introduced by #12. Previously we cannot handle multiple output directories, but 1.6.2 started support for it.

[pacey]

It's mainly just the SE_NO_SERIALVERSIONID because we use the with (object) {} block a lot. But maybe that shouldn't be reported as a bug?

[KengoTODA]

OK, you think it's false positive of SpotBugs core, right? Then I recommend you to issue a ticket at https://github.com/spotbugs/spotbugs/issues It was designed for Java language, so it may lack consideration for other languages like this.

I believe this Gradle plugin itself has no problem; #12 is just working well. Let me close this issue. Thank you! :)