GithubHelp home page GithubHelp logo

ReconnectingClient prints "Lost connection" for old nodes when another one is added - while requests go through just fine about folsom HOT 4 OPEN

spotify avatar spotify commented on August 15, 2024
ReconnectingClient prints "Lost connection" for old nodes when another one is added - while requests go through just fine

from folsom.

Comments (4)

spkrka avatar spkrka commented on August 15, 2024

Thanks for the report! It sounds it's possible that the old clients are still trying to reconnect. I'll investigate it further.

from folsom.

spkrka avatar spkrka commented on August 15, 2024

Actually... looks like this is intentional. When reconnecting, there's a 60 second shutdown delay by default: https://github.com/spotify/folsom/blob/master/folsom/src/main/java/com/spotify/folsom/ketama/SrvKetamaClient.java#L206

You can reconfigure the shutdown delay if you want.

from folsom.

alexeyOnGitHub avatar alexeyOnGitHub commented on August 15, 2024

right, my point is specifically about the log message.
I was thinking maybe the log message could be changed to make it explicit that the connection was not suddenly lost, but it was due to the planned shutdown. e.g. check if (shutdown) ... and then print different messages depending on whether it is a sudden connection loss vs. planned shutdown.

the message is somewhat confusing and scary otherwise.

from folsom.

spkrka avatar spkrka commented on August 15, 2024

I'll look into how much work it would be to introduce pending shutdowns and silence the logs for those.

from folsom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.