GithubHelp home page GithubHelp logo

Comments (5)

BalestraPatrick avatar BalestraPatrick commented on June 15, 2024 3

This is a good suggestion, fully agreed. We built XCMetrics with a plugin system so that you would be able to attach custom metadata to the information sent. But we also realize that there's a set of metrics that would be useful for people not to reimplement over and over again in separate plugins. There are a couple of ways to address this:

  • Include the git branch (and maybe other basic info about the git status) in a new field inside XCMetrics. This would probably cause the backend to have to migrate all existing tables due to the fact that a new field was added. We would need to evaluate this properly before making a decision to go down this route.
  • A second approach could be to provide standard implementations for common plugins directly in this repo. This would maybe look like a new package called XCMetricsPlugins that would containd default implementation for common plugins that people may want to use. You could then create your own custom version of XCMetrics (as described here).

I like the second option because this avoids adding all kind of configuration flags to the main XCMetrics tool such as --git_dir because some people may or may not want to provide/collect those information.

Maybe the rest of the team (@ecamacho @polac24 @aleksandergrzyb) have more opinions on the best way to approach this.

from xcmetrics.

ecamacho avatar ecamacho commented on June 15, 2024 3

I think it makes sense to go with the second approach. We will need new package to have the plugins sooner or later. And this is the perfect case to start with. And also the thermal throttling one that we provide in the documentation.

from xcmetrics.

frandelarosa avatar frandelarosa commented on June 15, 2024 2

+1 for this improvement!

from xcmetrics.

BalestraPatrick avatar BalestraPatrick commented on June 15, 2024 2

Fixed by #15 so I'll close this. Thanks @schlagelk!

from xcmetrics.

BalestraPatrick avatar BalestraPatrick commented on June 15, 2024

To add some more details, we are internally tracking a few information other than just the git branch name, which should be possible to do if we go with the second approach:

  • user_email (this would be fully redacted or semi-redacted via hashing)
  • branch
  • branch_created_at
  • dirty
  • sha
  • describe

from xcmetrics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.