Busy loop recreating state.json on invalid .pcap files about pkappa2

[peace-maker]

The problem appears to be that the problematic file isn't removed from the mgr.importJobs list on failure.

Here it returns that 0 files were processed when one of the pcaps in the batch fail to parse.

pkappa2/internal/index/builder/builder.go

Lines 103 to 106 in 73e39cd

	pcapInfo, pcapPackages, err := readPackets(pcapDir, pcapFilename, knownPcapInfo)
	if err != nil {
	return 0, nil, err
	}

The caller only logs the error and continues anyway

pkappa2/internal/index/manager/manager.go

Lines 362 to 365 in 73e39cd

	processedFiles, createdIndexes, err := mgr.builder.FromPcap(mgr.PcapDir, filenames, existingIndexes)
	if err != nil {
	log.Printf("importPcapJob(%q) failed: %s", filenames, err)
	}

And eventually tries to remove processed files from the job queue, but since processedFiles is 0 this will go on forever.

pkappa2/internal/index/manager/manager.go

Lines 404 to 410 in 73e39cd

	// remove finished job from queue
	mgr.importJobs = mgr.importJobs[processedFiles:]
	// start new import job if there are more queued
	if len(mgr.importJobs) >= 1 {
	idxs, rel := mgr.getIndexesCopy(0)
	go mgr.importPcapJob(mgr.importJobs[:], mgr.nextStreamID, idxs, rel)
	}

The error handling of the Builder.FromPcap function seems bogous. Are there any errors where it's useful to retry? Otherwise I'd just ignore the failing files and continue instead of return. All the other early returns need to be looked at as well.

[peace-maker]

pkappa2 refuses to start after it received an invalid pcap once as well. So the problematic pcaps need to be ignored during startup as well. I don't know if we want to delete them upon receival, but maybe moving into an "invalid" folder for later analysis might be good?

pkappa2/internal/index/builder/builder.go

Lines 53 to 56 in 73e39cd

	info, _, err = readPackets(pcapDir, p.Name(), nil)
	if err != nil {
	return nil, err
	}

[spq]

i have used some of your patches but left out some that I don't think are needed to fix this and modified some others to have as small an impact as possible.
could you confirm that this is fixed?

[peace-maker]

It appears to be solved now. Thank you!