Comments (3)
I suppose following what Backstage does might be a good idea, although it does feel like a bit of a workaround that was just added to work with the new aws-sdk version.
We don't use AWS S3 internally, thus the region value does not actually matter to us, so do feel free to open a PR that adds
us-east-1
as a default.With this approach, the region is not a breaking change any more.
I don't quite understand this, what do you mean by the region being a breaking change?
Because when I check the release page https://github.com/spreadshirt/backstage-plugin-s3/releases/tag/%40spreadshirt%2Fbackstage-plugin-s3-viewer-common%400.3.0
It says
e83665c: BREAKING: Migrated to AWS-SDK version 3. Now the platform config requires a new field called region. If not present, the plugin will fail on startup.
So it's a breaking change, isn't it?
from backstage-plugin-s3.
I suppose following what Backstage does might be a good idea, although it does feel like a bit of a workaround that was just added to work with the new aws-sdk version.
We don't use AWS S3 internally, thus the region value does not actually matter to us, so do feel free to open a PR that adds us-east-1
as a default.
With this approach, the region is not a breaking change any more.
I don't quite understand this, what do you mean by the region being a breaking change?
from backstage-plugin-s3.
Ah yes, that makes sense. :) If a default is introduced then there will still have been a breaking change, but not if you skip the version with the required region parameter and go directly to one with a new default.
from backstage-plugin-s3.
Related Issues (10)
- Abstract to also allow GCS and Azure? HOT 3
- Missing 'Authorization' header when download file HOT 2
- Configure with IAM HOT 18
- buckets, 404 Not Found HOT 3
- Folder structure, problem HOT 19
- Add yourself to Community Plugin Directory HOT 2
- Version @spreadshirt/[email protected] breaks the frontend HOT 6
- Property 'auth' does not exist on type 'PluginEnvironment' HOT 1
- Property 'httpAuth' does not exist on type 'PluginEnvironment'. HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backstage-plugin-s3.