GithubHelp home page GithubHelp logo

Comments (14)

jumph4x avatar jumph4x commented on August 14, 2024

Potentially related to the fact that 6debe07 (master tip) is post Spree 2.4 integration work. Try rolling back to before that set of commits.

from spree-product-assembly.

JDutil avatar JDutil commented on August 14, 2024

If you're on a 2.1.5 app (not sure why that would be fresh) you should try the 2-1-stable branch not master.

from spree-product-assembly.

Salet avatar Salet commented on August 14, 2024

I'm on the 2.4.5 version, not 2.1. My bad. Will try 2.4-beta branch this evening and will let you know.

from spree-product-assembly.

Salet avatar Salet commented on August 14, 2024

It looks like 5c6eb7c on master fixed my problem.

from spree-product-assembly.

yf6 avatar yf6 commented on August 14, 2024

This is happening again on 2-4-beta with 5c8b9bf undoing 5c6eb7c :(

from spree-product-assembly.

JDutil avatar JDutil commented on August 14, 2024

@yf6 I would make sure your actually on the latest 2-4-beta the fix should still be in place there.

from spree-product-assembly.

yf6 avatar yf6 commented on August 14, 2024

@JDutil I'm on latest 2-4-beta, and nope the check of if defined is not there
https://github.com/spree-contrib/spree-product-assembly/blob/2-4-beta/app/serializers/spree/wombat/assembly_shipment_serializer.rb#L35

from spree-product-assembly.

JDutil avatar JDutil commented on August 14, 2024

The check should not matter as the serializer is not loaded unless your using spree_wombat:
https://github.com/spree-contrib/spree-product-assembly/blob/master/lib/spree_product_assembly/engine.rb#L12

from spree-product-assembly.

yf6 avatar yf6 commented on August 14, 2024

This is interesting. I realized that the AssemblyShipmentSerializer wasn't required by the line you mentioned, but actually by polyglot. I'll go debug it more, not sure if it's something related to this gem anymore, but just in case:

...assembly_shipment_serializer.rb:3:in `<module:Wombat>': uninitialized constant Spree::Wombat::ShipmentSerializer (NameError)
    from .../gems/spree-product-assembly-90475e4c1d92/app/serializers/spree/wombat/assembly_shipment_serializer.rb:2:in `<module:Spree>'
    from .../gems/spree-product-assembly-90475e4c1d92/app/serializers/spree/wombat/assembly_shipment_serializer.rb:1:in `<top (required)>'
    from .../lib/ruby/gems/2.0.0/gems/polyglot-0.3.5/lib/polyglot.rb:65:in `require'

from spree-product-assembly.

BeDepraved avatar BeDepraved commented on August 14, 2024

I'm running into this same issue. I have a post on stack exchange

http://stackoverflow.com/questions/32492557/spree-product-assembly-crashes-in-production

I know it says this is closed, but this is still happening on my install.

from spree-product-assembly.

yf6 avatar yf6 commented on August 14, 2024

@BeDepraved I don't think I ever fully resolved the issue, ended up just including the wombat gem to get things going. :(

from spree-product-assembly.

BeDepraved avatar BeDepraved commented on August 14, 2024

Well that did it @yf6 thank you for the response. Never even crossed my mind. Thought I don't need wombat so...

from spree-product-assembly.

yf6 avatar yf6 commented on August 14, 2024

yeah we are not using wombat either, but hey that fixed it - definitely feels dirty doing that though :-P

from spree-product-assembly.

inyerade avatar inyerade commented on August 14, 2024

install wombat gem is a workaround but not a fix I think.

from spree-product-assembly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.