Relation#first with finder options is deprecated about spree_wishlist

[radar]

@brchristian please provide the information we ask for in the Contributing Guidelines.

Thanks!

[brchristian]

@radar Sorry for not being more specific! In fact, I referenced the wrong branch, as this is happening in 2-2, not in 2-1.

The difference seems to be that there is this commit 56f1f23 from @joneslee85 in the 2-1 branch that (among some other changes) changed the deprecated wishlist finder syntax from self.wishlists.first(:conditions => ["is_default = ?", true]) to self.wishlists.where(is_default: true).first.

In the master branch, we have this commit ef2a4ee from @futhr that (among other changes) fixes that very same deprecation as well.

Not sure how we ended up with two different fixes to the same thing, one for 2-1 and one for master, and neither for 2-2!

I'd suggest perhaps cherry picking one of those commits as you see fit onto the 2-2 branch.

[radar]

Thanks @brchristian. I've (finally) applied the patches to the 2-2-stable branch.

[futhr]

👍