Comments (6)
I think if we returned order.user.nil?
within the eligible
check of that promotion rule then it would work the same way. Do you think so too?
from spree_auth_devise.
Sorry, that should've been order.user.present?
.
from spree_auth_devise.
Please try out radar/spree's master or 2-1-stable branch and let me know if that fixes this issue.
from spree_auth_devise.
Thanks a lot @radar. I didn't know where to fix it (spree or here). Because of that I didn't create a pull request. Maybe next time :) .
Works as expected :) .
I'll leave this open until you merged your changes to spree/spree.
from spree_auth_devise.
Thanks for the confirmation!
On Thu, Jan 16, 2014 at 12:04 AM, Daniel Renner [email protected]
wrote:
Thanks a lot @radar. I didn't know where to fix it (spree or here). Because of that I didn't create a pull request. Maybe next time :) .
Works as expected :) .I'll leave this open until you merged your changes to spree/spree.
Reply to this email directly or view it on GitHub:
#153 (comment)
from spree_auth_devise.
Merged to spree/spree. Thanks a lot @radar !!!
spree/spree@f7e1ddb
from spree_auth_devise.
Related Issues (20)
- login error devise 4.3.0 HOT 10
- Authorization failure page is rendered for not authenticated user
- Spree::Api 'checkouts#update' in production mode causes exception in Metal decorator HOT 1
- Bypass option is deprecated
- Multiple issues with specs
- Login without email impossible due to unique index on `email` column
- Devise Syntax Error HOT 2
- customize user confirmation email url HOT 1
- How can I set up the devise lockable module?
- Alerts are duplicated
- Users can't be really destroyed
- Order token is persisted on logout
- No Way For Users To Re-send The Account Confirmation Email HOT 1
- UserRegistrationsController won't inherit from Spree::BaseController
- 2-Factor Authentication HOT 2
- ArgumentError:wrong number of arguments (given 0, expected 1) on Spree::User#send_confirmation_instructions (spree_auth_devise 4.3.0) HOT 6
- Spree backend user session fallback root path is not admin_path
- Uninitialized constant Spree::UsersController with spree legacy frontend HOT 2
- 4.5.0 breaks rails version resolution (bundler) HOT 1
- URL Generation issue after Admin login HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spree_auth_devise.