Comments (4)
https://github.com/spreedly/gala/compare/verify?expand=1
from gala.
@mrezentes can we go ahead and make it a PR pls?
from gala.
I have squashed the commits, tests are passing and I am ready to merge. My only question is about deploying core. I am guessing that I need to bundle, run tests, make empty commit with test message and deploy? @rwdaigle
from gala.
We should create a separate issue in Core to discuss the specifics of that.
But, there is some work we need to do there to properly expose the new sig
validation error case...
On Mon, Dec 14, 2015 at 2:34 PM Miki Rezentes [email protected]
wrote:
I have squashed the commits, tests are passing and I am ready to merge. My
only question is about deploying core. I am guessing that I need to bundle,
run tests, make empty commit with test message and deploy? @rwdaigle
https://github.com/rwdaigle—
Reply to this email directly or view it on GitHub
#1 (comment).
from gala.
Related Issues (12)
- Support applicationData hash HOT 2
- Ensure that comparison is constant time
- Missing a license HOT 3
- Distribute Gala as a Ruby gem HOT 5
- Move away from aead, unmaintained HOT 1
- ArgumentError: ciphertext failed authentication step HOT 3
- In test what is @merchant_id to be filled with? HOT 2
- Test failing with InvalidSignatureError HOT 1
- Bump openssl HOT 4
- MerchantOID question...
- New gem release HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gala.