GithubHelp home page GithubHelp logo

Comments (8)

ryanjbaxter avatar ryanjbaxter commented on September 27, 2024 1

That is basically the same as what we already say in the documentation

within the applications configuration coming from the config server

from spring-cloud-config.

ryanjbaxter avatar ryanjbaxter commented on September 27, 2024 1

No the key is the terms "applications configuration". This is referring to the the application's configuration being served up from the config server which is stored in Git, Vault, or any other environment repository.

from spring-cloud-config.

Junuu avatar Junuu commented on September 27, 2024 1

Thanks for the quick reflection!

from spring-cloud-config.

Junuu avatar Junuu commented on September 27, 2024

Does the term config server refer to an external repository like Git or Valut?

I think the yml configuration in Git or Valut etc is the remote configuration.

So I made the mistake of thinking of the Config Server term as the Spring Cloud Config Server and writing the Override property in that server's application.yml.

But in the end, I realized that I should have written the Override property in the application-local.yml of the Git repository.

This could be an error in translation as I don't speak English very well.

Thank you for your response.

from spring-cloud-config.

Junuu avatar Junuu commented on September 27, 2024

Thank you for your prompt response.

I appreciate your assistance in clarifying the documentation. Your explanation has certainly helped me understand the context better. However, I believe that the current wording might still be a bit confusing for others as well.

I suggest making the following change in the documentation:

as-is

If you enable config first bootstrap, you can allow client applications to override configuration from the config server by placing two properties within the applications configuration coming from the config server.

to-be

"If you enable config first bootstrap, you can allow client settings to override configuration from the config server by placing two properties within the applications configuration, which may include settings from external environment repositories such as Valut and Git."

If you find this suggestion reasonable, I would be more than happy to create a Pull Request to implement the proposed change. However, if you have any reservations or prefer an alternative approach, please feel free to discuss it further or close this issue accordingly.

Once again, thank you for your help and consideration.

Thank you.

from spring-cloud-config.

ryanjbaxter avatar ryanjbaxter commented on September 27, 2024

Thanks, I would just change the wording slightly...

If you enable config first bootstrap, you can allow client settings to override configuration from the config server by placing two properties within the applications configuration residing in the external environment repository(for example Git, Vault, SVN, etc) used by the config server.

How does that sound?

from spring-cloud-config.

Buzzardo avatar Buzzardo commented on September 27, 2024

I'd change that to:

If you enable config-first bootstrap, you can let client settings override configuration from the config server by placing two properties within the applications configuration that reside in the external environment repository (for example, Git, Vault, SVN, and others) used by the config server.

from spring-cloud-config.

ryanjbaxter avatar ryanjbaxter commented on September 27, 2024

Thanks @Buzzardo lets go with that!

from spring-cloud-config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.