Comments (28)
Useful for those who can't (or won't) use webflux.
from spring-cloud-gateway.
The initial implementation is there. Track the TODO list #2949 (comment) for additional things for M1. Remaining TODO's will get added to new issues for upcoming milestones.
from spring-cloud-gateway.
No
from spring-cloud-gateway.
+1 as Project Loom getting finalized. It's good to have Spring MVC based Gateway.
from spring-cloud-gateway.
Next week, but this was released in M1
from spring-cloud-gateway.
@spencergibb
This function is very interesting.
I will try to change my application from webflux to mvc with upcoming spring boot 3.2 and virtual thread.
from spring-cloud-gateway.
Thanks @spencergibb. I am pretty confident that a lot of people may be looking for replacement of @EnableZuulProxy. So either a blog post or some form of documentation on this will be extremely helpful. May be we can request Josh long to do a Spring tip on this topic.
from spring-cloud-gateway.
I'm just curious. Will this issue be targeted for a 2.x release?
from spring-cloud-gateway.
@joshiste it will not be
from spring-cloud-gateway.
Hi Team,
I have implemented Spring cloud gateway and Eureka discovery server everything working fine.
Now I am trying to add OAUTH2 security at Spring cloud gateway, but I can see its not compatible with gateway.
Is it possible to implement oAuth2 at gateway if yes can anyone share sample code please.
from spring-cloud-gateway.
Is there any progress?
from spring-cloud-gateway.
Is there a plan to allow Spring MVC?
This prevents us from using our common libraries such logging filters in our gateway implementation.
from spring-cloud-gateway.
from spring-cloud-gateway.
@spencergibb we have been using spring cloud zuul with @EnableZuulProxy mode in an spring boot app which has some rest endpoints exposed with restcontoller. What is the suggestion to use spring cloud gateway in this situation
from spring-cloud-gateway.
@mohanrao only if you migrate to a webflux application. If you aren't doing anything serlvet specific and are using spring annotations, it shouldn't be too difficult.
from spring-cloud-gateway.
Thanks @spencergibb . I will try migrating to a web flux . Our application uses oracle so it's not a true migration for some/most of the rest endpoints
from spring-cloud-gateway.
+1 for this. My use case is actually quite simple -- I work for a large corporation and want to use spring cloud with a gateway service, but the security libraries to interact with corporate SSO are written in such a way that is extremely dependent on the Servlet Context (hard-coded HttpServletRequest objects throughout the entire stack). For better or worse, I'd be surprised if there's ever a reactive implementation of that library, so it simply doesn't work with spring cloud gateway. Assuming as of now, still no progress?
from spring-cloud-gateway.
Until it gets assigned a project or milestone, you can assume no progress.
from spring-cloud-gateway.
@spencergibb is there any mechanism available to vote to get this needs to assigned to a project or milestone
from spring-cloud-gateway.
The reaction in #36 (comment) is the only voting we have. Note, this is a major effort and basically a parallel implementation.
from spring-cloud-gateway.
Here's a super simple (read nowhere near close) webmvc.fn version https://github.com/spencergibb/spring-cloud-gateway/blob/92208270307f275693e0c5223e85c5572f1a6100/spring-cloud-gateway-fn/src/test/java/org/springframework/cloud/gateway/fn/webmvc/WebmvcIntegrationTests.java#L84
from spring-cloud-gateway.
Will this support equivalent of the /zuul/ prefix support (bypass dispatcher servlet) of NetFlix Zuul for uploading large files . Or does that not apply to the new architecture? If the use case is still valid, what is the equivalent way to handle it in new Spring MVC implementation of SCG.
from spring-cloud-gateway.
This will not bypass the dispatcher servlet. I do not know if that use case is valid outside of zuul
from spring-cloud-gateway.
I meant the original implementation in Netflix Zuul provided the /zuul/
prefix based bypass of DispatcherServlet
because of some suckiness (a comment I saw on SO - https://stackoverflow.com/a/32100705 ) in DispatcherServlet
, I think related to buffering of request/response or something like that. That will still be the issue in new SCG MVC implementation right? Hence my question. May be I am misunderstanding as to why originally /zuul/
support was added. And I did not mean to ask for exact /zuul/
prefix solution, but equivalent that deals with the original isuue.
from spring-cloud-gateway.
@sandipchitale reading my SO answer and after adding support for multipart formdata (file uploads), I believe (though I haven't verified) that the modifications I made to multipart handling for an MVC gateway will eliminate previous problems with zuul. Basically, I turn off multipart parsing for gateway requests.
863a199#diff-af291548ea3a7b7c047c3de2f9ef6d6ba8402251f8683be19056eb60dddde0eeR62-R75
from spring-cloud-gateway.
@spencergibb thanks for the hard work! May I know when the M2 will be released?
from spring-cloud-gateway.
We have an implementation in a SpringMVC (gateway+angular frontend app) with embedded @EnableZuulProxy. Now that NetFlix Zuul is EOLed we tried to implement some of this using ProxyExchange with mixed success.
It will be helpful if there was some guidance provided on how to replace @EnableZuulProxy functionality with Spring Cloud Gateway MVC.fn . Or the provided functionality is already doing what @EnableZuulProxy does?
from spring-cloud-gateway.
It may be the subject of a blog or something, but zuul hasn't been supported for a number of years. This implementation provides much more functionality than the zuul implementation though there are likely incompatibilities.
from spring-cloud-gateway.
Related Issues (20)
- [Question] Routing of the requests with multipart file upload limitations
- Migrate mvc proxy exchange properties to new namespace and deprecate old
- Migrate webflux proxy exchange properties to new namespace and deprecate old
- Migrate server-webflux properties to new namespace and deprecate old
- Migrate server-webmvc properties to new namespace and deprecate old
- Serve Single Page Applications as static files in Spring Cloud Gateway HOT 5
- Custom GlobalFilter will have undeterministic hehavior when the Order is the same value. HOT 3
- openfeign java.lang.NoClassDefFoundError: feign/Request$Options
- Route pointing to self can be bypassed by direct controller access
- Cors handling with spring cloudgateway mvc HOT 1
- SCG Redis ratelimiter solution has unavailable issues when redis has problems HOT 3
- How can i block"/actuator" endpoint in gateway HOT 3
- can anyone provide a spring-cloud-gateway-mvc sample? HOT 2
- LEAK: ByteBuf.release() error HOT 5
- The cache works differently if the value of local-response-cache.enabled is default false or explicitly false
- Load balance per route read timeout in spring-cloud-gateway-server-mvc HOT 1
- Ratelimiter not working with aws elasticache redis 7.1 HOT 9
- Gateway MVC ServerRequest body broken when created from another
- Required Gobalfilter type interface in Spring Cloud Gateway MVC, and instead of bean creation properties level routes configuration HOT 2
- direct memory always increases when adding custom filter to get request body size
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-cloud-gateway.