GithubHelp home page GithubHelp logo

Comments (8)

snicoll avatar snicoll commented on June 18, 2024

This might require keeping information on the verifier version somewhere apart (maybe here), since the dependencies within buildscript probably will not work with dependencyManagement.

What is the difference between spring-cloud-contract.version and verifier_version ? Are they ultimately referring to the same version?

How about using springCloudContractVersion for Gradle, that would be consistent with what we're doing atm.

The annoying issue is that we have to map a release train to a spring cloud contract version. I really would like avoid doing that if possible as it increases the maintenance on our side and the risk of inconsistency.

from start.spring.io.

OlgaMaciaszek avatar OlgaMaciaszek commented on June 18, 2024

The annoying issue is that we have to map a release train to a spring cloud contract version

Yes, that's what I meant - this is the Spring Cloud Contract version indeed, but we would probably have to map it.

from start.spring.io.

snicoll avatar snicoll commented on June 18, 2024

Correct but I am not keen to hardcode the mapping from Spring Cloud release train version to Spring Cloud contract version.

Do you have a proposal to solve this part? If so, we might need to move this one to the library as there is a missing feature we need to implement first.

from start.spring.io.

OlgaMaciaszek avatar OlgaMaciaszek commented on June 18, 2024

To consider: do not set up the plugin if Spring Rest Docs selected as a dependency.

from start.spring.io.

OlgaMaciaszek avatar OlgaMaciaszek commented on June 18, 2024

There is no way of simply deducing the plugin version from the release train, however, we are able to automate getting the plugin version from the Release Train - we do such things with our releaser tool, but it requires doing a call to github, parsing appropriate pom and getting the version. I could add this logic somewhere to initialzr. Alterantively, we could add another field in the config yaml and then just create a PR to update it automatically with the releaser whenever we run a new release. @snicoll would that be anacceptable solution?

from start.spring.io.

snicoll avatar snicoll commented on June 18, 2024

@OlgaMaciaszek thanks for the feedback. Can you share the code that would be required to get the version from the release train? If we implement something, I'd love to get some sort of generic feature (i.e. parsing boms and extracting relevant versions).

We can be pragmatic and consider the PR solution that would make sure it is consistent and implement a better solution later. Let's see the code and we can take it from there.

from start.spring.io.

OlgaMaciaszek avatar OlgaMaciaszek commented on June 18, 2024

@snicoll ok, will work on it next week and share the code here.

from start.spring.io.

mbhave avatar mbhave commented on June 18, 2024

Closing in favor of PR #154 .

from start.spring.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.