Comments (8)
This might require keeping information on the verifier version somewhere apart (maybe here), since the dependencies within buildscript probably will not work with dependencyManagement.
What is the difference between spring-cloud-contract.version
and verifier_version
? Are they ultimately referring to the same version?
How about using springCloudContractVersion
for Gradle, that would be consistent with what we're doing atm.
The annoying issue is that we have to map a release train to a spring cloud contract version. I really would like avoid doing that if possible as it increases the maintenance on our side and the risk of inconsistency.
from start.spring.io.
The annoying issue is that we have to map a release train to a spring cloud contract version
Yes, that's what I meant - this is the Spring Cloud Contract version indeed, but we would probably have to map it.
from start.spring.io.
Correct but I am not keen to hardcode the mapping from Spring Cloud release train version to Spring Cloud contract version.
Do you have a proposal to solve this part? If so, we might need to move this one to the library as there is a missing feature we need to implement first.
from start.spring.io.
To consider: do not set up the plugin if Spring Rest Docs selected as a dependency.
from start.spring.io.
There is no way of simply deducing the plugin version from the release train, however, we are able to automate getting the plugin version from the Release Train - we do such things with our releaser tool, but it requires doing a call to github, parsing appropriate pom and getting the version. I could add this logic somewhere to initialzr. Alterantively, we could add another field in the config yaml and then just create a PR to update it automatically with the releaser whenever we run a new release. @snicoll would that be anacceptable solution?
from start.spring.io.
@OlgaMaciaszek thanks for the feedback. Can you share the code that would be required to get the version from the release train? If we implement something, I'd love to get some sort of generic feature (i.e. parsing boms and extracting relevant versions).
We can be pragmatic and consider the PR solution that would make sure it is consistent and implement a better solution later. Let's see the code and we can take it from there.
from start.spring.io.
@snicoll ok, will work on it next week and share the code here.
from start.spring.io.
Closing in favor of PR #154 .
from start.spring.io.
Related Issues (20)
- Upgrade to Spring Modulith 1.1.0 and 1.0.3
- Add entries for Oracle Database starters HOT 3
- Wrong Implementation Of Resilience4J via Spring Cloud Circuitbreaker Added When Adding Spring Cloud Gateway HOT 10
- Upgrade to Spring Cloud 2023.0.0
- Upgrade to Spring Cloud Services 4.1.0
- Upgrade to Solace Spring Cloud 3.1.0 and enable Solace Spring Boot for Spring Boot 3.2.0
- Upgrade to Spring Cloud Azure 4.14.0 HOT 1
- Upgrade to Spring Cloud Azure 5.8.0
- Project generation fails when selecting Testcontainers, Oracle, and Zipkin
- Upgrade to Wavefront for Spring Boot 3.2.0 HOT 2
- Upgrade to Timefold 1.5.0 HOT 2
- Spring Boot 3.3.0-SNAPSHOT did not work HOT 2
- Starting from Kotlin 2.0, need to add `.kotlin` directory into `.gitignore` for Gradle based project HOT 1
- Unneccessary Modulith dependencies defined when using database access starters HOT 2
- Migrate build to GitHub actions HOT 2
- Upgrade to Spring Cloud Azure 5.9.0
- Use local storage to remember user choices HOT 4
- Upgrade to Spring Cloud Azure 5.9.1
- Fix broken link to Spring REST Docs reference documentation in help.md HOT 3
- Add ASA to the powered by line on the hamburger menu page
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from start.spring.io.