Testcontainers @DynamicPropertySource and @Container execution order doesn't work properly about spring-boot

[quaff]

You can try annotating @org.testcontainers.junit.jupiter.Testcontainers on class WithContainers.

But it will trigger another problem, the @DynamicPropertySource method is invoked twice from DynamicPropertiesContextCustomizer and DynamicPropertySourceMethodsImporter.

Thread [main] (Suspended (breakpoint at line 22 in TestContainerTests))	
	owns: DefaultContextCache  (id=82)	
	TestContainerTests.populateDynamicPropertyRegistry(DynamicPropertyRegistry) line: 22	
	NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]	
	NativeMethodAccessorImpl.invoke(Object, Object[]) line: 77	
	DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43	
	Method.invoke(Object, Object...) line: 568	
	ReflectionUtils.invokeMethod(Method, Object, Object...) line: 281	
	DynamicPropertiesContextCustomizer.lambda$buildDynamicPropertiesMap$3(DynamicPropertyRegistry, Method) line: 82	

Thread [main] (Suspended (breakpoint at line 22 in TestContainerTests))	
	owns: DefaultContextCache  (id=82)	
	TestContainerTests.populateDynamicPropertyRegistry(DynamicPropertyRegistry) line: 22	
	NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]	
	NativeMethodAccessorImpl.invoke(Object, Object[]) line: 77	
	DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43	
	Method.invoke(Object, Object...) line: 568	
	ReflectionUtils.invokeMethod(Method, Object, Object...) line: 281	
	DynamicPropertySourceMethodsImporter.lambda$registerDynamicPropertySources$0(DynamicPropertyRegistry, Method) line: 57	
	0x000000012f319850.accept(Object) line: not available	

Here is the test case:

package com.example.demo;

import org.junit.jupiter.api.Test;
import org.springframework.boot.testcontainers.context.ImportTestcontainers;
import org.springframework.context.annotation.Configuration;
import org.springframework.test.context.DynamicPropertyRegistry;
import org.springframework.test.context.DynamicPropertySource;
import org.springframework.test.context.junit.jupiter.SpringJUnitConfig;
import org.testcontainers.containers.PostgreSQLContainer;
import org.testcontainers.junit.jupiter.Container;
import org.testcontainers.junit.jupiter.Testcontainers;

@SpringJUnitConfig
//@Testcontainers
public class TestContainerTests {

	@Container
	static PostgreSQLContainer<?> container = new PostgreSQLContainer<>("postgres");

	@DynamicPropertySource
	static void populateDynamicPropertyRegistry(DynamicPropertyRegistry registry) {
		System.out.println(container.getMappedPort(5432));
	}

	@Test
	void test() {
	}

	@Configuration
	@ImportTestcontainers(TestContainerTests.class)
	static class Config {

	}

}

[wilkinsona]

The problem is that you're accessing the container directly within your @DynamicPropertySource method:

println(localStackContainer.getEndpointOverride(SQS))

This requires the container to have been started when the @DynamicPropertySource method is called, undoing the benefit of the registry's lazy nature where you register a property with a supplier for its value. Using a supplier means that the container does not have to have been started until the property is accessed which happens later in the application lifecycle.

This worked in 3.2.0 as the containers were started very early but that was at the expense of support for parallel startup being broken. This was fixed in #38831.

In summary, this only worked in 3.2.0 accidentally and, unfortunately, you'll have to make some changes to adapt to the way things now work. You can either remove println calls that access the container or move them into the supplier implementations where the values for the properties are being returned.