upgrade 3.2.6 corrupts published parent pom artifact about spring-boot

[wilkinsona]

The errors in the two cases are almost identical:

only whitespace content allowed before start tag and not P (position: START_DOCUMENT seen P... @1:2)

only whitespace content allowed before start tag and not P (position: START_DOCUMENT seen P... @1:1)

In each case, I believe that the deploy plugin is uploading a pom file but with jar file content.

[cstamas]

Well, here we face a multiple issues, and none of the are Maven or Deploy plugin related...

The MDEPLOY-318 reproducer does not work, in a sense, that m-deploy-p 3.1.1 nor 3.1.2 does not reproduce the issue mentioned here. It seems it is more the CI yaml script of user that causes this issue: https://gitlab.com/tub/test-maven-deploy/-/blob/f52e59829afd61a1294a4373ba7d752ecb97ebd5/.gitlab-ci.yml

Notice how user explicitly invoked jar:jar goal in after-script, this tells Maven "do create a JAR for me", and is basically circumventing lifecycle, that would go goal -> packaging -> lifecycle -> plugin invocation indirection. The POM has packaging=pom, but user forces Maven to make a JAR for it, which it obeys...

Maven should be used by invoking lifecycles, not (kinda like Ant) invoking plugins directly, see https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html

[tubbynl]

thank you

for the record; it does seem to publish correctly if i omit the jar:jar mojo for the tester project on https://gitlab.com/tub/test-maven-deploy i need to test it on the full project (multi-module containing the parent pom and other jar modules)

we've explicitly split it up like this to prevent triggering full project rebuilds in the after_script part

[wilkinsona]

i think it is an issue the maven-deploy-plugin:3.1.2 upgrade, i will try to raise an issue there but i dont have an account yet.

I think so too. This should be reported to the maintainers of the deploy plugin if someone has not already done so. Duplicates #40919.

[tubbynl]

tnx, my account is pending approval at apache, will report. #40919 talks about a jar being published to a wrong (artifactory) endpoint, this is pom being corrupted upon publishing but it could very well both have the same cause. reported here mainly if people encounter the same error :)

[tubbynl]

ah yes; will report it when my account gets approved :)

[tubbynl]

https://issues.apache.org/jira/browse/MDEPLOY-318

[tubbynl]

thank you for your helpfull insights @cstamas 👍