Comments (17)
Sounds good, @GregBragg !
Just open a PR in https://github.com/spring-projects/spring-integration and we will proceed from there with details if any!
Thanks
from spring-integration-extensions.
The spring-integration-smb
has made it into the core project: spring-projects/spring-integration@7ad71d3
Big thanks to @GregBragg !
from spring-integration-extensions.
Example for how unmaintained this project is, and why this is so confusing and misleading - this project references the AWS and the Kafka connector, just for a README that will tell the user that this connector isn't in this repo. This repo of course has some other connectors like Twitter, but it won't reference that in the README. @artembilan Please migrate this and improve this project for the next user.
from spring-integration-extensions.
Thanks for bring this up, @ipanimnim .
We already such a discussion in other place: spring-projects/spring-integration#3720.
Feel free to continue over there.
from spring-integration-extensions.
@artembilan The discussion we had there was out of subject (the issue was about the request for more extensions in general). This issue seems to fit more. Anyway, was there any progress in this subject since the last discussion?
from spring-integration-extensions.
Thanks, @almogtavor , for the pointer.
No, there is no progress for those your requests yet.
I'm not familiar with those projects to make an immediate solution.
Plus I'm only one committer for these Spring Integration projects over here.
Therefore bear with me how it is slow done.
There are also some other not-work related stuff to deal with...
As I always say, the contribution is welcome: https://github.com/spring-projects/spring-integration/blob/main/CONTRIBUTING.adoc
And having an external PR is really a good way to expedite the progress.
from spring-integration-extensions.
@artembilan would you accept PRs that will move this & other repos like spring-integration-aws
to the main repo?
from spring-integration-extensions.
Not yet.
We are discussing internally what would be acceptable from this repo.
For example twitter
is obsolete and based on the library which already out of support. So, it cannot be moved anywhere.
Perhaps to a new repo for obsolete modules a-la spring-integration-attic
.
The AWS cannot be moved because it is based on Spring Boot and we cannot have circular dependencies.
And so on, so on. Too many questions for every single repo.
For example what do you think about Spring Integration modules in Google GCP project, Microsoft Azure, Alibaba etc?.
At a glance only Cassandra, Hazelcast, Zip, SMB are good to go.
Although I may confirm fully that Goovy DSL is 100% candidate to go into spring-integration-core
right now.
Thanks
from spring-integration-extensions.
Why AWS is based on spring boot? About GCP, Alibaba and so, their fine as long as being referenced from the docs. All the others that are relevant should be in the same place, which should encourage to add more connectors over time.
from spring-integration-extensions.
Please, they are not called connectors. They are channel adapters. That's exactly a canonical name from EIP: https://www.enterpriseintegrationpatterns.com/patterns/messaging/ChannelAdapter.html.
The Spring Integration AWS uses Spring Cloud AWS , which is based on Spring Cloud, which, in turn, is based on Spring Boot. And the last one exactly uses Spring Integration. Therefore Spring Integration AWS has to be the last one in the release train.
If we can come up with the solution on a plain AWS SDK (v2?), then it indeed can go to Spring Integration.
Some other channel adapter impls may have similar concerns.
So, better to have such a discussion in a discrete manner: per module/project.
from spring-integration-extensions.
How does the AWS module different from the Mongo module? They both rely on other Spring based projects. And in general the main point is that all of the channel adapters that can sit in the main repo, should sit there. Otherwise, at least to be documented on the main docs/ referenced from the main docs.
from spring-integration-extensions.
There is a difference to be dependent on a plain Spring module and the one based on Spring Boot. The auto-configuration from Spring Boot and Spring Cloud rely changes a play over here.
If Spring Cloud AWS is divided to separate projects: plain components and auto-configuration, then it could make difference for Spring Integration AWS. But not at the moment when
Therefore Spring Integration are not those channel adapters that can sit in the main repo.
Yes, we discussed with you in other places that we are going to mention this and other vendor-specific channel adapters in the doc.
from spring-integration-extensions.
I think the AWS channel adapters should stay at their own repo (as long as being referenced from the official SI docs - which they currently do not). When it comes to channel adapters for Twitter, Cassandra, and more, I think they have to be in the SI official repo, and as fast as possible, since people don't know of them and think that they just don't exist (which happened to me). @artembilan would you accept a copy-paste PR that moves the following folders:
- spring-integration-cassandra
- spring-integration-etcd
- spring-integration-groovy-dsl
- spring-integration-hazelcast
- spring-integration-cassandra
- spring-integration-smb
- spring-integration-smpp
- spring-integration-print
- spring-integration-social-twitter
- spring-integration-xquery
- spring-integration-xmpp
I think this is also a good chance to merge back:
- spring-integration-splunk
spring-integration-ip-extensions
, spring-integration-jgroups
, spring-integration-jt400
, spring-integration-voldemort
seems pretty abandoned but if you want this can be added.
I think this move is no less than a must. These extensions don't even appear in the table, their docs don't appear in the main docs, and nobody actually has an opportunity to know about them.
from spring-integration-extensions.
We cannot move twitter back because we really have moved it here for the reason its base library was EoL: https://spring.io/blog/2018/07/03/spring-social-end-of-life-announcement.
It can come back only if there is other library we can make channel adapters based on.
The xmpp
is already in the main project: https://docs.spring.io/spring-integration/docs/current/reference/html/xmpp.html#xmpp.
And there is no such an extension over here.
You duplicated cassandra
.
We cannot move xquery
because seems for me it is not based on the Open Source licensed library.
I doubt in print
and smpp
- they really are very abandoned.
I doubt it is going to be just easy copy/paste PRs.
But we can try, of course!
As I said before: the Groovy DSL is the best candidate to go. So, let's start from it for now!
from spring-integration-extensions.
So:
- spring-integration-cassandra
- spring-integration-etcd
- spring-integration-groovy-dsl
- spring-integration-hazelcast
- spring-integration-smb
Seems good?
from spring-integration-extensions.
I think so. Let’s see how it goes!
from spring-integration-extensions.
@artembilan Me again... I have a branch ready for the SMB extension to be migrated into the main Spring Integration repo that is ready for your review. Let me know if I can create a PR for it, or whether you would like me to hold off.
Thanks!
from spring-integration-extensions.
Related Issues (20)
- spring-integration-smb 1.1 does not work with spring integration 5.2. HOT 4
- Upgrade Cassandra to version 4 HOT 1
- spring-integration-smb memory leak in SmbShare HOT 1
- Memory leak with org.springframework.integration.hazelcast.leader.LeaderInitiator HOT 2
- HazelcastContext does not implement getRole() method HOT 1
- Hazelcast LeaderInitiator inconsistent yielding HOT 5
- Zip: If there is a problem with unzipping and deleteFiles is true then original file is deleted
- zip: Exception during unzip deletes original file if deleteFiles is true. HOT 1
- Spring Integration SMB Half Upload on Graceful Shutdown HOT 4
- spring-integration-zip: Status? HOT 4
- Deprecate fileReplace option from SmbSessionFactory and remove it in future HOT 7
- Spring Integration LockRegistry support for Cosmos HOT 1
- HazelcastMessageStore should use keySet instead of values HOT 3
- Doesn't build with Java 17, and old jcifs HOT 1
- SMB: FileTransferringMessageHandler not creating folders HOT 7
- Can't create nested directories on SMB share HOT 1
- Consider using another samba support library instead of jcifs HOT 2
- Restarting HZ cluster will not re-establish any leadership HOT 5
- spring-integration-smb not supports Spring 6 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-integration-extensions.