GithubHelp home page GithubHelp logo

Comments (4)

srackham avatar srackham commented on May 18, 2024

Resolved with the introduction of file history caching in Drake v1.0.0-rc2.

from drake.

duncanmak avatar duncanmak commented on May 18, 2024

@srackham I'm using Drake 1.5.2 and I noticed that on Windows, the mtime check in isOutOfDate is returning true all the time.

isOutOfDate: build\index.html: true: build\index.html
from: {"size":532,"mtime":"2022-06-07T21:29:05.186Z"}
to:   {"size":532,"mtime":"2022-06-07T23:21:29.811Z"}

I was scanning the same article you referred to, mtime comparison considered harmful, and I wonder if a better check could be implemented instead of checking that the result of Date.toISOString is !==.

An interesting note, I only see this error when running in Windows - on Linux (in WSL, no less), isOutOfDate returns false as expected after running the same target a second time.

from drake.

srackham avatar srackham commented on May 18, 2024

Thanks for this, very interesting. I'll look into it when I get some free time.

from drake.

srackham avatar srackham commented on May 18, 2024

@duncanmak The only possibilities I can think of are that somehow the Drake cache file is not being updated after a sucessful task execution (if the task action is executed sucessfully then the Drake cache should be updated) or the information returned by the Deno.statSync API is stale.

Try cloning the Drake repo and running the Drake tests on WSL with deno run -A Drakefile.ts test command (I don't have WSL installed).

from drake.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.