Validate apparent size/distance of token makers about competition-simulator

[PeterJCLaw]

Ah, I'm not sure about reproducibility. This issue was raised based on source analysis, so it's possible that it's a different issue to what was seen in the forums. I think we ought to fix both though :)

[PeterJCLaw]

We should also do this for the arena wall markers, which may also be slightly wrong albeit for different reasons. It's possible that the same fix would work for both though.

[antoinepetty]

Similar issue being reported on the forum: https://studentrobotics.org/forum/viewtopic.php?f=10&t=110&p=416
But they only mention arena markers? I think it might be because the arena markers are the correct size whereas the token markers fully fit the face (as mentioned above)

[PeterJCLaw]

@RealOrangeOne unless we're going to drop vision from SR2021 I think this issue should be considered a blocker. Was it intentional that it be omitted from the SR2021 milestone?

[RealOrangeOne]

Mostly that, partly that I had an (apparently false) recollection that we couldn't reliably reproduce this.

[PeterJCLaw]

Note: this is only relevant if we are going ahead with using a vision based system for SR2021.

[PeterJCLaw]

We're not doing vision this year.

[PeterJCLaw]

Blocked: for SR2021 we're not running with a camera, so this isn't relevant this year.
I'm leaving this open however as the camera code is still present and still has this bug. If we go back to having the camera we'll need to fix this.

[PeterJCLaw]

SR2023 has a camera again, so this is unblocked.