Default options in main CMakeLists.txt about sqlitecpp

[SRombauts]

Hi, thanks for this, I will take the time to think about it.
Le 26 mars 2014 20:07, "Kartik Kumar" [email protected] a écrit :

Hi Sébastien,

After spending a lot of time looking through the code, I realised that the
problems I was having with the newest code is due to the default options
switched on in the main CMakeLists.txt file.

The options that caused me problems are:

1. SQLITE_ENABLE_COLUMN_METADATA: this is switched on by default, however
   under Mac OS X, the native SQLite library is not built with column name
   support. I tried building a new version using Homebrew but couldn't for the
   life of me get SQLiteCpp to link to it.
2. SQLITE_ENABLE_ASSERT_HANDLER: this is also switched on by default,
   however from what I can see, it will always result in linking problems
   unless the user provides an implementation of assertion_failed().

In the first case, it might still be alright to leave the option on,
however if a large number of users have pre-built versions of SQLite
installed, this might cause issues.

In the second case, it seems like default case will cause problems out of
the box for a new user who has no custom implementation of
assertion_failed().

After switching both these options off, I could link to the SQLiteCpp
static library without any problems.

Would it be an idea to switch both these options off by default? Feels
like the safer option in general.

Regards,

Kartik

Reply to this email directly or view it on GitHubhttps://github.com//issues/19
.

[SRombauts]

Thanks a lot @kartikkumar, I took into consideration what you proposed, and make both OFF.

Regards,
SRombauts

[kartikkumar]

Awesome! Thanks for the quick action!

Kartik