No "ToTransientMethod" method in BinderUntyped about zenject-2019

[svermeulen]

You can just use ToMethod instead, which is transient.

[svermeulen]

Oh wait, you're right, only BinderGeneric has ToMethod surprisingly. I'll fix that.

[cgarciae]

@svermeulen Thanks! I looked at the code inside BinderUntyped and there only seem to be singleton methods so the fix doesn't look that simple.

[svermeulen]

Ok I pushed a change that adds that method. I tested it in the unit tests but will wait to hear from you whether that solves your problem before closing this item

[cgarciae]

I am having a small problem that didn't happen in ToSingleMethod, in the new extension method

        public static void ToPrefab(this BinderUntyped binder, String prefabLocation, Type type)
        {
            binder.ToMethod((ctx) => {
                var obj = Resources.Load(prefabLocation) as GameObject;
                return ctx.Container.InstantiatePrefabForComponent(type, obj) as MonoBehaviour;
            });
        }

TContract in ToMethod<TContract> gets set as MonoBehaviour because its the only sensible type I can cast to. However, the actual type of obj is type (obj.GetType() == type) and that type is known to extend MonoBehaviour.

So Zenject complains

ZenjectBindException: Invalid type given during bind command. Expected type 'UnityEngine.MonoBehaviour' to derive from type

I actually commented your code (the part that check types) so it didn't throw that exception but I got

ZenjectException: Assert hit!
ModestTree.Assert.Throw (System.String message) (at Assets/Lib/Zenject/Internal/Assert.cs:195)
ModestTree.Assert.That (Boolean condition) (at Assets/Lib/Zenject/Internal/Assert.cs:29)
Zenject.MethodProvider`1[UnityEngine.MonoBehaviour].GetInstance (Zenject.InjectContext context) (at Assets/Lib/Zenject/Main/Scripts/Providers/MethodProvider.cs:25)
Zenject.DiContainer.Resolve (Zenject.InjectContext context) (at Assets/Lib/Zenject/Main/Scripts/Main/DiContainer.cs:578)
Zenject.DiContainer.Resolve (System.Type contractType) (at Assets/Lib/Zenject/Main/Scripts/Main/DiContainer.cs:1175)

I actually need something that binds the method type as a parameter like this

        public static void ToPrefab(this BinderUntyped binder, String prefabLocation, Type type)
        {
            //Pass "type" into ToMethod
            binder.ToMethod(type, (ctx) => {
                var obj = Resources.Load(prefabLocation) as GameObject;
                return ctx.Container.InstantiatePrefabForComponent(type, obj) as MonoBehaviour;
            });
        }

[cgarciae]

If passing type as a parameter is not possible, is the exception I get when I comment your code due to the same exception as yesterday (something about not having a CompositionRoot)?

[svermeulen]

Ok I added a non-generic version of ToMethod, try that. What errors are you getting now?

[cgarciae]

Works!!!!!!!!!!!!!!!!!!!!!!!!

Thanks man. Now I am able to define Routes like this with my framework

    [Route("some/route")]
    public class SomeRouteView : MonoBehaviour
    {
        [PostInject]
        public void PostConstruct(...) {
            ...
        }
    }

and start and configure like this

    public class Startup : MVCApp
    {
        public override void Configure(IApplication app, DiContainer container)
        {
            //Set view dependencies
        }

        public override void Init(IRouter router)
        {
            router.GoTo(
                url: "some/view",
                body: 42
            );
        }
    }

the framework looks for classes annotated with Route and wires the dependencies with your code!!!

[svermeulen]

Ok great :)

Sounds like a cool setup