Comments (2)
Nice digging, yeh, that seems sensible to change.
Not many references to Key()
here, maybe more elsewhere in the dependencies?
grep -R "it.Key()" . -l
./graph/builder.go
./plugins2/names/about.go
from go-ssb.
Method
Key
Usages in All Places (7 usages found)
Unclassified (7 usages found)
go-ssb (6 usages found)
graph (4 usages found)
builder.go (4 usages found)
Build (1 usage found)
143 k := it.Key()
DeleteAuthor (1 usage found)
108 k := it.Key()
Follows (1 usage found)
265 k := it.Key()
Subfeeds (1 usage found)
339 k := it.Key()
plugins2/names (2 usages found)
about.go (2 usages found)
All (1 usage found)
99 k := it.Key()
CollectedFor (1 usage found)
163 k := it.Key()
/home/filip/go/pkg/mod/github.com/ssbc/[email protected]/internal/persist/badger (1 usage found)
saver.go (1 usage found)
List (1 usage found)
107 k := it.Key()
I can see that the key is being taken out of the transaction and stored in a slice in margaret. If I am correct about this then this could be a source of really weird bugs.
from go-ssb.
Related Issues (20)
- TestFSCK flaking HOT 2
- TestNullFetched is flaky
- TestMetafeedIndexes is flaky HOT 4
- TestPrivateGroupsManualDecrypt is flaky HOT 2
- Remove usage of PushSource?
- Fix REUSE badge HOT 3
- Where are the indexes actually being set? HOT 5
- What's the difference between the publish log and the receive log? HOT 3
- Figure out licensing problems
- Figure out why TestStartup seemingly always triggers a 30 second timeout
- Can we get rid of logBuilder?
- Probable race condition in Gossip plugin's FeedManager
- Require tests passing before merge once flaky tests go away HOT 1
- Race condition between index Margaret queries
- Incorrect parsing of high-precision timestamps HOT 17
- TestPrivMsgsFromGo failing HOT 2
- Capitalization in sbotcli's remoteKey flag HOT 2
- Ways forward for go-ssb? HOT 5
- Possible problem with publishing before finishing syncing one's own feed from another node
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-ssb.